Skip to content

Commit

Permalink
MINOR: Log at info level when pending member joins a group (#17495)
Browse files Browse the repository at this point in the history
When a dynamic member joins a group, it sends two JOIN_GROUP requests.
The first request doesn't have a member id and returns
MEMBER_ID_REQUIRED with a broker-generated member id. The second request
includes the broker-generated member id and joins the group for real.

We emit a log message at info level for the first join request, but not
the second. Log the second join request at info level too.

Reviewers: David Jacot <[email protected]>
  • Loading branch information
squah-confluent authored Oct 21, 2024
1 parent 25e8e4c commit 6e8df29
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ private[group] class GroupCoordinator(
s"for pending member with memberId=$memberId")
}

debug(s"Pending dynamic member with id $memberId joins group ${group.groupId} in " +
info(s"Pending dynamic member with id $memberId joins group ${group.groupId} in " +
s"${group.currentState} state. Adding to the group now.")
addMemberAndRebalance(rebalanceTimeoutMs, sessionTimeoutMs, memberId, None,
clientId, clientHost, protocolType, protocols, group, responseCallback, reason)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4321,7 +4321,7 @@ private CoordinatorResult<Void, CoordinatorRecord> classicGroupJoinExistingMembe
groupInstanceId + " for pending member with memberId=" + memberId);
}

log.debug("Pending dynamic member with id {} joins group {} in {} state. Adding to the group now.",
log.info("Pending dynamic member with id {} joins group {} in {} state. Adding to the group now.",
memberId, group.groupId(), group.currentState());

return addMemberThenRebalanceOrCompleteJoin(
Expand Down

0 comments on commit 6e8df29

Please sign in to comment.