Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR; Update the properties files for controller with advertised.listeners #16473

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

tinaselenge
Copy link
Collaborator

@tinaselenge tinaselenge commented Jun 27, 2024

Controller nodes can be configured with advertised listeners after #16235.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@jsancio jsancio self-assigned this Jun 27, 2024
@jsancio jsancio changed the title MINOR: Update the properties files for controller with advertised.listeners MINOR; Update the properties files for controller with advertised.listeners Jun 27, 2024
Copy link
Member

@jsancio jsancio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM. Just one minor suggestion.

@@ -39,6 +39,11 @@ controller.quorum.voters=1@localhost:9093
# listeners = PLAINTEXT://your.host.name:9092
listeners=CONTROLLER://:9093

# Listener name, hostname and port the controller will advertise to admin clients.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

# Listener name, hostname and port the controller will advertise to admin clients, broker nodes and controller nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants