KAFKA-13093: Log compaction should write new segments with record version v2 (KIP-724) #18321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
ijuma
force-pushed
the
kafka-13093-log-compaction-write-record-v2
branch
from
f38e108 to
d41a6e2
Compare
github-actions
bot
added
the
storage
ijuma
commented
Dec 28, 2024
| @@ -2580,6 +2580,23 @@ class UnifiedLogTest { | |||
| assertEquals(None, log.leaderEpochCache.flatMap(_.latestEpoch.toScala)) | |||
| } | |||
|
|
|||
| @Test | |||
| def testLeaderEpochCacheCreatedAfterMessageFormatUpgrade(): Unit = { | |||
There was a problem hiding this comment.
This test was originally removed via #18267 - added it back and modified it to take into account that the leader epoch cache always exists now (since the configured record version is always V2).
…sion v2 (KIP-724)
… longer supported
…e it always creates it now
…'s still a useful test
ijuma
commented
Dec 29, 2024
| @@ -262,12 +261,6 @@ object LogTestUtils { | |||
| def listProducerSnapshotOffsets(logDir: File): Seq[Long] = | |||
| ProducerStateManager.listSnapshotFiles(logDir).asScala.map(_.offset).sorted.toSeq | |||
|
|
|||
| def assertLeaderEpochCacheEmpty(log: UnifiedLog): Unit = { | |||
ijuma
commented
Dec 29, 2024
| @@ -134,6 +135,131 @@ class LogCleanerParameterizedIntegrationTest extends AbstractLogCleanerIntegrati | |||
| assertEquals(toMap(messages), toMap(read), "Contents of the map shouldn't change") | |||
| } | |||
|
|
|||
| @ParameterizedTest | |||
| @ArgumentsSource(classOf[LogCleanerParameterizedIntegrationTest.ExcludeZstd]) | |||
| def testCleanerWithMessageFormatV0V1V2(compressionType: CompressionType): Unit = { | |||
There was a problem hiding this comment.
The tests added in this class were originally removed via #18267 - added them back, modified them to fit the new reality and extended them to include more extensive verification of the log after compaction.
ijuma
force-pushed
the
kafka-13093-log-compaction-write-record-v2
branch
from
0ede54e to
a50bd5d
Compare
|
@junrao Would you be able to review this PR? I would like to include it in Apache Kafka 4.0, if possible - it completes KIP-724. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert v0/v1 record batches to v2 during compaction even if said record batches would be
written with no change otherwise. A few important details:
CreateTimeand thetimestamp is
-1.KAFKA-4298workaround is no longer needed since the conversion to V2 fixesthe issue too.
supported.
config is effectively always V2.
Add integration tests, these tests existed before #18267 - restored, modified and
extended them.
Committer Checklist (excluded from commit message)