MINOR: Replace deprecated Project.buildDir property in gradle
#18501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
frankvicky
force-pushed
the
replace-deprecated-builddir-property
branch
from
f821867 to
30ba2ec
Compare
mimaison
reviewed
Jan 13, 2025
build.gradle
Outdated
| @@ -1162,7 +1162,7 @@ project(':core') { | |||
| if (versions.baseScala == '2.13') { | |||
| scoverageScalaVersion = '2.13.9' // there's no newer 2.13 artifact, org.scoverage:scalac-scoverage-plugin_2.13.9:2.0.11 is the latest as of now | |||
| } | |||
| reportDir = file("${rootProject.buildDir}/scoverage") | |||
| reportDir = file("${rootProject.layout.buildDirectory.get().asFile.path}/scoverage") | |||
There was a problem hiding this comment.
I think we don't need rootProject..
frankvicky
force-pushed
the
replace-deprecated-builddir-property
branch
from
30ba2ec to
be8f9c1
Compare
frankvicky
force-pushed
the
replace-deprecated-builddir-property
branch
from
be8f9c1 to
a7ee9a7
Compare
frankvicky
force-pushed
the
replace-deprecated-builddir-property
branch
from
a7ee9a7 to
60dcb9e
Compare
|
Failed tests are not related to the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference: https://docs.gradle.org/8.10.2/dsl/org.gradle.api.Project.html#org.gradle.api.Project:buildDir
buidDiris deprecated and will be removed in the next major version of Gradle. We should replace it withgetLayout().getBuildDirectory().Committer Checklist (excluded from commit message)