KAFKA-18405: Remove ZooKeeper logic from DynamicBrokerConfig #18508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
approved these changes
Jan 13, 2025
|
@FrankYang0529 Do you plan to handle #18384 (comment) in this PR? or this PR is used to remove @mimaison WDYT? |
|
Hi @chia7712, I will handle it in this PR because this Jira is created by that thread. Thanks. |
FrankYang0529
force-pushed
the
KAFKA-18405
branch
from
cb12723 to
ab32a19
Compare
|
Hi @chia7712, I have updated PR to handle "advertised.listeners" and failed cases in CI are flaky:
|
chia7712
reviewed
Jan 14, 2025
| @@ -1032,15 +988,8 @@ class DynamicListenerConfig(server: KafkaBroker) extends BrokerReconfigurable wi | |||
| if (oldConfig.effectiveListenerSecurityProtocolMap(listenerName) != newConfig.effectiveListenerSecurityProtocolMap(listenerName)) | |||
| throw new ConfigException(s"Security protocol cannot be updated for existing listener $listenerName") | |||
| } | |||
| if (!newAdvertisedListeners.contains(newConfig.interBrokerListenerName)) | |||
| if (!oldAdvertisedListeners.contains(newConfig.interBrokerListenerName)) | |||
There was a problem hiding this comment.
Is interBrokerListenerName a kind of dynamic config? If not, KafkaConfig has checked it in initialization.
| def validateReconfiguration(newConfig: KafkaConfig): Unit = { | ||
| val oldConfig = server.config | ||
| val newListeners = listenersToMap(newConfig.listeners) | ||
| val newAdvertisedListeners = listenersToMap(newConfig.effectiveAdvertisedBrokerListeners) | ||
| val oldAdvertisedListeners = listenersToMap(oldConfig.effectiveAdvertisedBrokerListeners) |
There was a problem hiding this comment.
it seems we can use Set instead of Map, right?
FrankYang0529
force-pushed
the
KAFKA-18405
branch
from
ab32a19 to
121c75b
Compare
3 tasks
FrankYang0529
force-pushed
the
KAFKA-18405
branch
from
121c75b to
bb66345
Compare
Signed-off-by: PoAn Yang <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
force-pushed
the
KAFKA-18405
branch
from
bb66345 to
eb24f7e
Compare
|
Hi @chia7712, I address all comments. Could you take a look when you have time? Thank you. |
chia7712
approved these changes
Jan 16, 2025
| @@ -900,7 +881,6 @@ object DynamicListenerConfig { | |||
| */ | |||
| val ReconfigurableConfigs = Set( | |||
| // Listener configs | |||
| SocketServerConfigs.ADVERTISED_LISTENERS_CONFIG, | |||
There was a problem hiding this comment.
@FrankYang0529 Could you please file a minor follow-up to add this change to zk2kraft.html?
There was a problem hiding this comment.
Yes, I will create a minor PR for it. Thanks.
chia7712
pushed a commit
that referenced
this pull request
Jan 16, 2025
Reviewers: Chia-Ping Tsai <[email protected]>
3 tasks
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
…8508) Reviewers: Chia-Ping Tsai <[email protected]>
airlock-confluentinc bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
…8508) Reviewers: Chia-Ping Tsai <[email protected]>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
…8508) Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zkClientOptin DynamicBrokerConfig.advertised.listenersfromReconfigurableConfigsand related logic.Committer Checklist (excluded from commit message)