Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX remove protected_branches from asf.yaml #19182

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

mumrah
Copy link
Member

@mumrah mumrah commented Mar 10, 2025

The new parser seems not to support the null "~" thing. Instead, we'll just remove this section completely.

@github-actions github-actions bot added the small Small PRs label Mar 10, 2025
@chia7712
Copy link
Member

The new parser seems not to support the null "~" thing

according to https://github.com/apache/infrastructure-asfyaml, it seems protected_branches: ~ is valid.

To completely remove all branch protection rules, set the protected_branches section to null:

github:
  protected_branches: ~

@mumrah
Copy link
Member Author

mumrah commented Mar 11, 2025

We are using the "next gen" .asf.yaml parser which has had a few bugs. I think this (lack of support for ~) was one of them. I'm waiting to hear back from Infra if this change is needed or not. If you don't mind approving, I'll merge or close this PR depending on Infra's recommendation.

Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will unblock the merge :)

How can I monitor the infrastructure's response (or next gen parser)? thanks

@mumrah
Copy link
Member Author

mumrah commented Mar 11, 2025

I've been chatting with them in #asfinfra https://infra.apache.org/slack.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Small PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants