KAFKA-19550: Integration test for Streams-related Admin APIs [1/N] #20244

lucliu1108 · 2025-07-26T02:49:23Z

This change adds:

Integration test for Admin#describeStreamsGroups API
Integration test for Admin#deleteStreamsGroup API

Reviewers: Alieh Saeedi [email protected], Lucas Brutschy
[email protected]

core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala

aliehsaeedii · 2025-08-04T14:14:14Z

Thanks, @lucliu1108, for the PR. I added a couple of comments/suggestions.

core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala

lucasbru

Thanks for the PR! This is mostly looking good to me. I left two comments. The main thing is that I would like to avoid the extra dependency from core -> streams. I think it may be possible, following what I did in AuthorizerIntegrationTest.

core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala

core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala

lucasbru

Left a few more minor comments. But this is mostly LGTM

core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala

core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala

core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala

Copilot

Pull Request Overview

This PR adds integration tests for Streams-related Admin APIs, specifically for describeStreamsGroups and deleteStreamsGroups functionality. The changes enable testing of Kafka Streams group management through the Admin client.

Key changes:

Added createStreamsGroup helper method to create test Streams groups with proper configuration
Enhanced existing group listing tests to include Streams groups
Added comprehensive integration tests for describing and deleting Streams groups

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
PlaintextAdminIntegrationTest.scala	Added two new test methods and updated existing group listing test to handle Streams groups
IntegrationTestHarness.scala	Added helper method to create Streams groups for testing purposes

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala

core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala

lucasbru

There are still some whitespace changes

core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala

core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala

core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala

lucasbru

LGTM, thanks!

chia7712 · 2025-09-05T16:40:12Z

core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala

@@ -2589,8 +2594,11 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegrationTest {
    shareGroupConfig.put(ConsumerConfig.GROUP_ID_CONFIG, shareGroupId)
    val shareGroup = createShareConsumer(configOverrides = shareGroupConfig)

-    val config = createConfig
-    client = Admin.create(config)
+    val streamsGroup = createStreamsGroup(


The consumer may create testTopicName due to a metadata update, causing the subsequent client.createTopics call to fail since the topic already exists.

see https://github.com/apache/kafka/actions/runs/17495296037/job/49695550299?pr=20472

@lucliu1108 WDYT? Perhaps we could create the topic first?

That makes sense. Thanks for pointing out! I'll make a patch for that @chia7712

Patch created: #20496. Thanks! @chia7712

lucliu1108 added 2 commits July 25, 2025 15:51

fix indentation

6c4fba4

clean up test

c272552

github-actions bot added triage PRs from the community core Kafka Broker build Gradle build or GitHub Actions small Small PRs and removed triage PRs from the community labels Jul 26, 2025

lucliu1108 changed the title ~~KSTREAMS-7427 Integration test for Streams-related Admin APIs[1/N]~~ KAFKA-19550 Integration test for Streams-related Admin APIs[1/N] Jul 26, 2025

lucliu1108 added 2 commits July 25, 2025 23:44

add depency

503483c

add deleteStreamsGroup integration test

71e0ab0

github-actions bot removed the small Small PRs label Jul 28, 2025

lucliu1108 added 6 commits July 28, 2025 18:10

remove redundant code

6524912

remove parts that shouldn't be included

d923d01

cleanup spacing

4196434

Merge branch 'trunk' into KSTREAMS-7247

a3da136

reorganize code

316a417

reorganize code

a50ed7e

lucliu1108 mentioned this pull request Jul 30, 2025

KAFKA-19565: Integration test for Streams-related Admin APIs [2/N] #20266

Open

aliehsaeedii reviewed Aug 4, 2025

View reviewed changes

core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala Outdated Show resolved Hide resolved

aliehsaeedii reviewed Aug 4, 2025

View reviewed changes

core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala Outdated Show resolved Hide resolved

lucliu1108 added 5 commits August 4, 2025 17:41

Merge branch 'trunk' into KSTREAMS-7247

ab67b5b

revise describeStreamsGroup wait until stable

ad59b00

add integration test for listgroups for streams protocol

03f64e4

move list streams group test into existing listGroups test

f33fddb

Merge branch 'trunk' into KSTREAMS-7247

885e626

aliehsaeedii reviewed Aug 26, 2025

View reviewed changes

lucliu1108 added 2 commits August 26, 2025 10:08

Merge branch 'trunk' into KSTREAMS-7247

d9246de

modify tests

069a406

lucasbru reviewed Aug 28, 2025

View reviewed changes

core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala Outdated Show resolved Hide resolved

core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala Show resolved Hide resolved

lucasbru added the KIP-1071 PRs related to KIP-1071 label Aug 28, 2025

lucliu1108 added 3 commits September 1, 2025 12:47

Merge branch 'trunk' into KSTREAMS-7247

1e9a87a

revise streamsgroup creation

ac83e37

remove unncessary gradle dependencies

7e6afe0

github-actions bot added the tests Test fixes (including flaky tests) label Sep 1, 2025

move consumer poll to test

7f75f03

lucasbru reviewed Sep 2, 2025

View reviewed changes

lucasbru requested a review from Copilot September 2, 2025 19:27

This comment was marked as outdated.

Sign in to view

lucliu1108 added 5 commits September 2, 2025 15:45

reformat code

6464811

reformat code

926e7e4

reformat code

00f271a

remove redundant consumer config for tests

c6a42bd

add back file last changeline

a1f1e88

lucliu1108 requested a review from Copilot September 2, 2025 21:07

Copilot AI reviewed Sep 2, 2025

View reviewed changes

lucliu1108 added 2 commits September 2, 2025 16:50

modify code based on copilot suggestions

aed6c1d

fix spacing

04433c7

lucliu1108 requested a review from lucasbru September 2, 2025 22:16

move topic creation inside try block

be27bd8

lucasbru reviewed Sep 3, 2025

View reviewed changes

Apply suggestions from code review

b996f95

lucasbru reviewed Sep 3, 2025

View reviewed changes

Apply suggestions from code review

7b036a7

lucasbru changed the title ~~KAFKA-19550 Integration test for Streams-related Admin APIs[1/N]~~ KAFKA-19550: Integration test for Streams-related Admin APIs [1/N] Sep 3, 2025

lucasbru approved these changes Sep 4, 2025

View reviewed changes

lucasbru merged commit a81f08d into apache:trunk Sep 4, 2025
35 of 37 checks passed

chia7712 reviewed Sep 5, 2025

View reviewed changes

lucliu1108 mentioned this pull request Sep 6, 2025

MINOR: Move topic creation before consumer creation in testListGroups integration test #20496

Open

KAFKA-19550: Integration test for Streams-related Admin APIs [1/N] #20244

KAFKA-19550: Integration test for Streams-related Admin APIs [1/N] #20244

Conversation

lucliu1108 commented Jul 26, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aliehsaeedii commented Aug 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lucasbru left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lucasbru left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lucasbru left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lucasbru left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chia7712 Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

lucliu1108 Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lucliu1108 Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lucliu1108 commented Jul 26, 2025 •

edited by github-actions bot

Loading

lucliu1108 Sep 6, 2025 •

edited

Loading