KAFKA-19638: Set dummy ProcessorRecordContext for processor init #20403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjsax
reviewed
Aug 25, 2025
| @@ -1104,11 +1104,18 @@ private void initializeTopology() { | |||
| // initialize the task by initializing all its processor nodes in the topology | |||
| log.trace("Initializing processor nodes of the topology"); | |||
| for (final ProcessorNode<?, ?, ?, ?> node : topology.processors()) { | |||
| processorContext.setCurrentNode(node); | |||
| final ProcessorRecordContext recordContext = new ProcessorRecordContext( | |||
| time.milliseconds(), | |||
There was a problem hiding this comment.
Not sure if this would be what we want? We would set a single TS, and if init() runs for a longer period of time, all records would get the same TS?
We might need to change ProcessorRecordContext to have a "time function" instead of a hard-coded value? For a record at hand, the time function would be () -> record.timestamp() and return the same value each time, and for this dummy context, we would use () -> time.milliseconds().
But need to think about this more, and figure out what design we really want to get to, and what the splash radius of changing ProcessorRecordContext would be :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete this text and replace it with a detailed description of your change. The
PR title and body will become the squashed commit message.
If you would like to tag individuals, add some commentary, upload images, or
include other supplemental information that should not be part of the eventual
commit message, please use a separate comment.
If applicable, please include a summary of the testing strategy (including
rationale) for the proposed change. Unit and/or integration tests are expected
for any behavior change and system tests should be considered for larger
changes.