-
Notifications
You must be signed in to change notification settings - Fork 14.6k
KAFKA-15307: Kafka Streams configuration docs outdated #20408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Tagging @mjsax for review. Also, I need help in rendering the |
You can run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a pass.
@mimaison -- I don't think we should block the next RC on this PR. Might take a little longer. We can always update kafka-site
later.
Should we change the above line to
Is it required to be the specific version |
Yes... Seems this is incorrect for many years... and when we move off hard-coded versions to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. One smaller nit comment. Also great find about the version issues. Let's include this fix.
Co-authored-by: Matthias J. Sax <[email protected]>
made the required changes @mjsax |
Will hold of merging until 4.1 went out, and I can cherry-pick to AK 4.1 branch, and you can do a PR against |
Sounds good! Thank you! Also, I would like to suggest a minor addition to this page - Contributing Website Documentation Changes I would like to add a step to preview changes from kafka code repository which seems to be missing. Like as mentioned here - #20408 (comment) |
Here is the PR apache/kafka-site#716 :) |
Feel free to merge and backport to 4.1. I've bumped 4.1 to 4.1.1-SNAPSHOT, it's open to commits |
Added new section for window serdes and update Streams configuration
page accordingly.
Reviewers: Matthias J. Sax [email protected]