-
Notifications
You must be signed in to change notification settings - Fork 14.6k
MINOR: suppress build warning #20424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,35 +55,35 @@ public void testParseEmptyArgAsValid() { | |
List<String> argArray = List.of("my.empty.property=", "my.empty.property1"); | ||
Properties props = CommandLineUtils.parseKeyValueArgs(argArray); | ||
|
||
assertEquals(props.getProperty("my.empty.property"), "", "Value of a key with missing value should be an empty string"); | ||
assertEquals(props.getProperty("my.empty.property1"), "", "Value of a key with missing value with no delimiter should be an empty string"); | ||
assertEquals("", props.getProperty("my.empty.property"), "Value of a key with missing value should be an empty string"); | ||
assertEquals("", props.getProperty("my.empty.property1"), "Value of a key with missing value with no delimiter should be an empty string"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixing incorrect order for expected vs actual value. |
||
} | ||
|
||
@Test | ||
public void testParseSingleArg() { | ||
List<String> argArray = List.of("my.property=value"); | ||
Properties props = CommandLineUtils.parseKeyValueArgs(argArray); | ||
|
||
assertEquals(props.getProperty("my.property"), "value", "Value of a single property should be 'value'"); | ||
assertEquals("value", props.getProperty("my.property"), "Value of a single property should be 'value'"); | ||
} | ||
|
||
@Test | ||
public void testParseArgs() { | ||
List<String> argArray = List.of("first.property=first", "second.property=second"); | ||
Properties props = CommandLineUtils.parseKeyValueArgs(argArray); | ||
|
||
assertEquals(props.getProperty("first.property"), "first", "Value of first property should be 'first'"); | ||
assertEquals(props.getProperty("second.property"), "second", "Value of second property should be 'second'"); | ||
assertEquals("first", props.getProperty("first.property"), "Value of first property should be 'first'"); | ||
assertEquals("second", props.getProperty("second.property"), "Value of second property should be 'second'"); | ||
} | ||
|
||
@Test | ||
public void testParseArgsWithMultipleDelimiters() { | ||
List<String> argArray = List.of("first.property==first", "second.property=second=", "third.property=thi=rd"); | ||
Properties props = CommandLineUtils.parseKeyValueArgs(argArray); | ||
|
||
assertEquals(props.getProperty("first.property"), "=first", "Value of first property should be '=first'"); | ||
assertEquals(props.getProperty("second.property"), "second=", "Value of second property should be 'second='"); | ||
assertEquals(props.getProperty("third.property"), "thi=rd", "Value of second property should be 'thi=rd'"); | ||
assertEquals("=first", props.getProperty("first.property"), "Value of first property should be '=first'"); | ||
assertEquals("second=", props.getProperty("second.property"), "Value of second property should be 'second='"); | ||
assertEquals("thi=rd", props.getProperty("third.property"), "Value of second property should be 'thi=rd'"); | ||
} | ||
|
||
Properties props = new Properties(); | ||
|
@@ -272,6 +272,7 @@ public void testInitializeBootstrapPropertiesWithBothBootstraps() { | |
Optional.of("127.0.0.2:9094"), Optional.of("127.0.0.3:9095"))).getMessage()); | ||
} | ||
|
||
@SuppressWarnings("unchecked") | ||
private OptionSpec<String> createMockOptionSpec(String name) { | ||
OptionSpec<String> spec = mock(OptionSpec.class); | ||
when(spec.toString()).thenReturn("[" + name.replaceAll("--", "") + "]"); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be included by
-Xlint:all
, right?https://github.com/apache/kafka/blob/trunk/build.gradle#L129
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to remove it -- it seems something is off with my local setup -- I don't see the full warn output as you do, and adding this flag did make a difference for me... so 🤷