MINOR Rename RecordSnapshotWriter.Builder.setMaxBatchSize to setMaxBatchSizeBytes #20446
Conversation
…tchSizeBytes The original name is confusing which could cause engineers to make a mistake and confuse the size with some other unit like number of records.
Changed maxBatchSize to maxBatchSizeBytes in BatchAccumulator.
|
It seems the word |
@chia7712 do you mean it's still used here (and a few other places)? If that is the case, on the one hand this is just a refactoring; on the other hand it's not an area of the code I'm familiar with. Not a huge deal to change - it seems like other usages are mostly local variables. IG it can't hurt. What do you think? |
It's not a big deal, so it's fine to leave it as it is 😄 |
The original name is confusing which could cause engineers to make a
mistake and confuse the
batchSizewith some other unit like number ofrecords.
Reviewers: Chia-Ping Tsai [email protected]