MINOR: migrate listenerListToEndPoints from CoreUtils to AbstractKafkaConfig #20567
+90
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
TaiJuWu
force-pushed
the
absCOnfig
branch
3 times, most recently
from
a2fe028 to
6c1d6a3
Compare
TaiJuWu
changed the title
TaiJuWu
changed the title
chia7712
reviewed
Sep 24, 2025
| if (distinctListenerNames != endPoints.size()) { | ||
| throw new IllegalArgumentException("Each listener must have a different name, listeners: " + listeners); | ||
| } | ||
|
|
There was a problem hiding this comment.
It can return early if requireDistinctPorts is false, right? for example:
private static void validate(List<Endpoint> endPoints, List<String> listeners, boolean requireDistinctPorts) {
long distinct = endPoints.stream().map(Endpoint::listener).distinct().count();
if (distinct != endPoints.size()) {
throw new IllegalArgumentException("Each listener must have a different name, listeners: " + listeners);
}
if (!requireDistinctPorts) return;
...
chia7712
reviewed
Sep 25, 2025
| List<Endpoint> duplicatesWithIpHosts = partitionedByValidIp.get(true); | ||
| List<Endpoint> duplicatesWithoutIpHosts = partitionedByValidIp.get(false); | ||
|
|
||
| if (requireDistinctPorts) { |
There was a problem hiding this comment.
requireDistinctPorts is always false, right?
m1a2st
reviewed
Sep 25, 2025
| assertEquals(listenerListToEndPoints(util.List.of("PLAINTEXT://:9092")).asScala, conf.listeners) | ||
| assertNull(conf.listeners.find(_.securityProtocol == SecurityProtocol.PLAINTEXT).get.host) | ||
| assertEquals(conf.effectiveAdvertisedBrokerListeners, listenerListToEndPoints(util.List.of("PLAINTEXT://:9092"))) | ||
| assertEquals(conf.effectiveAdvertisedBrokerListeners, listenerListToEndPoints(util.List.of("PLAINTEXT://:9092")).asScala) |
There was a problem hiding this comment.
It should be in reverse order.
Suggested change
| assertEquals(conf.effectiveAdvertisedBrokerListeners, listenerListToEndPoints(util.List.of("PLAINTEXT://:9092")).asScala) | |
| assertEquals(listenerListToEndPoints(util.List.of("PLAINTEXT://:9092")).asScala, conf.effectiveAdvertisedBrokerListeners)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate listenerListToEndPoints from CoreUtils to AbstractKafkaConfig