Skip to content

Conversation

RaidenE1
Copy link
Contributor

@RaidenE1 RaidenE1 commented Sep 22, 2025

In the create topic request we send a CreateTopic request in an
Envelope, so we need to also unpack the response correctly

Reviewers: Lucas Brutschy [email protected]

@github-actions github-actions bot added triage PRs from the community core Kafka Broker labels Sep 22, 2025
@lucasbru lucasbru self-assigned this Sep 23, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the AutoTopicCreationManager to properly handle envelope responses for CreateTopics requests. When sending CreateTopics requests through envelopes, the responses need to be unwrapped from the EnvelopeResponse wrapper to access the actual CreateTopicsResponse data.

  • Adds envelope response handling to both sendCreateTopicRequest and createStreamsInternalTopics methods
  • Implements proper error handling for envelope-level errors and parsing failures
  • Adds comprehensive test coverage for various envelope response scenarios

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
core/src/main/scala/kafka/server/AutoTopicCreationManager.scala Adds envelope response unwrapping logic to handle CreateTopics responses correctly
core/src/test/scala/unit/kafka/server/AutoTopicCreationManagerTest.scala Adds comprehensive test cases for envelope response handling scenarios

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot removed the triage PRs from the community label Sep 24, 2025
@lucasbru lucasbru changed the title MINOR: handle envelope response MINOR: Handle envelope response in AutoTopicCreationManager Sep 24, 2025
@lucasbru lucasbru requested a review from Copilot September 24, 2025 09:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants