-
Notifications
You must be signed in to change notification settings - Fork 14.7k
MINOR: Handle envelope response in AutoTopicCreationManager #20569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the AutoTopicCreationManager to properly handle envelope responses for CreateTopics requests. When sending CreateTopics requests through envelopes, the responses need to be unwrapped from the EnvelopeResponse wrapper to access the actual CreateTopicsResponse data.
- Adds envelope response handling to both
sendCreateTopicRequest
andcreateStreamsInternalTopics
methods - Implements proper error handling for envelope-level errors and parsing failures
- Adds comprehensive test coverage for various envelope response scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
core/src/main/scala/kafka/server/AutoTopicCreationManager.scala | Adds envelope response unwrapping logic to handle CreateTopics responses correctly |
core/src/test/scala/unit/kafka/server/AutoTopicCreationManagerTest.scala | Adds comprehensive test cases for envelope response handling scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
core/src/test/scala/unit/kafka/server/AutoTopicCreationManagerTest.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/kafka/server/AutoTopicCreationManager.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/kafka/server/AutoTopicCreationManager.scala
Outdated
Show resolved
Hide resolved
…Test.scala Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
core/src/test/scala/unit/kafka/server/AutoTopicCreationManagerTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/server/AutoTopicCreationManagerTest.scala
Outdated
Show resolved
Hide resolved
…Test.scala Co-authored-by: Copilot <[email protected]>
In the create topic request we send a CreateTopic request in an
Envelope, so we need to also unpack the response correctly
Reviewers: Lucas Brutschy [email protected]