Skip to content

MINOR: Remove logContext arrtibute from StreamsGroup and CoordinatorRuntime #20572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2025
Merged

MINOR: Remove logContext arrtibute from StreamsGroup and CoordinatorRuntime #20572

merged 2 commits into from
Sep 28, 2025

Conversation

DL1231
Copy link
Contributor

@DL1231 DL1231 commented Sep 23, 2025 •
edited by github-actions bot
Loading

The logContext attribute in StreamsGroup and CoordinatorRuntime is
not used anymore. This patch removes it.

Reviewers: Ken Huang [email protected], TengYao Chi
[email protected], Chia-Ping Tsai [email protected]

@github-actions github-actions bot added triage PRs from the community group-coordinator small Small PRs labels Sep 23, 2025
m1a2st
m1a2st reviewed Sep 23, 2025
View reviewed changes
Copy link
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove LogContext from the SslChannelBuilder constructor?

kafka/clients/src/main/java/org/apache/kafka/common/network/SslChannelBuilder.java

Line 57 in dbe9d34

LogContext logContext) {

@github-actions github-actions bot added clients and removed triage PRs from the community labels Sep 24, 2025
frankvicky
frankvicky approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@frankvicky frankvicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DL1231: LGTM

chia7712
chia7712 approved these changes Sep 28, 2025
View reviewed changes
Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 merged commit c2aeec4 into apache:trunk Sep 28, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 approved these changes

@frankvicky frankvicky frankvicky approved these changes

+1 more reviewer

@m1a2st m1a2st m1a2st approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ci-approved clients group-coordinator small Small PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DL1231 @chia7712 @frankvicky @m1a2st