Skip to content

Conversation

LoganZhuZzz
Copy link
Contributor

@LoganZhuZzz LoganZhuZzz commented Oct 10, 2025

These Javadocs describe the purpose, prerequisites (leader, committed
epoch/HWM), validation logic, asynchronous steps (for AddVoter), and the
complete list of potential error codes for each dynamic quorum
reconfiguration API.

Reviewers: Chia-Ping Tsai [email protected]

@github-actions github-actions bot added triage PRs from the community kraft small Small PRs labels Oct 10, 2025
@chia7712
Copy link
Member

@LoganZhuZzz thanks for this patch. Could you please add docs for handleUpdateVoterRequest as well?

@LoganZhuZzz LoganZhuZzz force-pushed the minor-doc4voter-in-raft-client branch from 25ee08d to 7b14a92 Compare October 14, 2025 02:15
@LoganZhuZzz
Copy link
Contributor Author

@LoganZhuZzz thanks for this patch. Could you please add docs for handleUpdateVoterRequest as well?

@chia7712 PTAL

Copy link

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

@chia7712 chia7712 changed the title MINOR: Add doc for AddVoter and RemoveVoter request handling in KafkaRaftClient MINOR: Add Javadoc for handleAddVoterRequest, handleRemoveVoterRequest, and handleUpdateVoterRequest in KafkaRaftClient.java Oct 18, 2025
@chia7712 chia7712 changed the title MINOR: Add Javadoc for handleAddVoterRequest, handleRemoveVoterRequest, and handleUpdateVoterRequest in KafkaRaftClient.java MINOR: Add Javadoc for handleAddVoterRequest, handleRemoveVoterRequest, and handleUpdateVoterRequest Oct 18, 2025
@chia7712 chia7712 changed the title MINOR: Add Javadoc for handleAddVoterRequest, handleRemoveVoterRequest, and handleUpdateVoterRequest MINOR: Javadoc for voter add/remove/update request handling Oct 18, 2025
@chia7712 chia7712 changed the title MINOR: Javadoc for voter add/remove/update request handling MINOR: Add Javadoc for handleAddVoterRequest, handleRemoveVoterRequest, and handleUpdateVoterRequest Oct 18, 2025
@chia7712 chia7712 merged commit bc63bef into apache:trunk Oct 18, 2025
29 checks passed
@github-actions github-actions bot removed needs-attention triage PRs from the community labels Oct 19, 2025
JimmyWang6 pushed a commit to JimmyWang6/jimmy-KAFKA-14048 that referenced this pull request Oct 19, 2025
…t, and handleUpdateVoterRequest (apache#20680)

These Javadocs describe the purpose, prerequisites (leader, committed
epoch/HWM), validation logic, asynchronous steps (for AddVoter), and the
complete list of potential error codes for each dynamic quorum
reconfiguration API.

Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants