Skip to content

MINOR: Replace long with AtomicLong for thread safety in MockProducer #20694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

MINOR: Replace long with AtomicLong for thread safety in MockProducer #20694

wants to merge 1 commit into from
+4 −4

Conversation

jim0987795064
Copy link
Contributor

@jim0987795064 jim0987795064 commented Oct 13, 2025 •
edited
Loading

  • Changes: Replace the long field commitCount in MockProducer with an AtomicLong to ensure thread-safe updates under concurrent access.

@github-actions github-actions bot added triage PRs from the community producer build Gradle build or GitHub Actions clients small Small PRs labels Oct 13, 2025
chia7712
chia7712 reviewed Oct 13, 2025
View reviewed changes
clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java
private boolean producerFenced;
private boolean sentOffsets;
private long commitCount = 0L;
private final AtomicLong commitCount = new AtomicLong(0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not guarantee that MockProducer is thread-safe

@github-actions github-actions bot removed the triage PRs from the community label Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chia7712 chia7712 chia7712 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

build Gradle build or GitHub Actions ci-approved clients producer small Small PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jim0987795064 @chia7712