KAFKA-18973 gracefully stopping test execution if .git does not exist #20703
+15
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
|
@lianetm Please review it |
chia7712
reviewed
Oct 21, 2025
|
|
||
| if (!gitFound) { | ||
| System.out.println("Skipping testVerifyEvolutionGit - not in a Git repository"); | ||
| return; // Skip test when running from source release without Git |
There was a problem hiding this comment.
How about using assumeTrue instead?
There was a problem hiding this comment.
Thanks that would be better. I have done the changes.
|
the flaky is traced by KAFKA-19513 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test logic covers three main scenarios:
Running from the Kafka Root Directory
Action: The test immediately finds the .git directory.
Result: It uses this location to correctly find the schema file and
runs the test successfully.
Running from a Subdirectory
Action: The test searches up the directory tree (e.g., from
generator/ or generator/src/test/java/).
Result: It finds the .git directory at the Kafka root, uses that
root to build the correct path to the schema file, and runs the test
successfully.
Running from a Source Release (No Git)
Action: The test searches all the way up the entire directory tree
to the filesystem root.
Result: It never finds the .git directory, and the test skips
gracefully with a message.
Reviewers: Chia-Ping Tsai [email protected]