-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Experiment kip 1035 #20709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Experiment kip 1035 #20709
Conversation
…o experiment-kip-1035
thanks @eduwercamacaro I wrote a test that verifies that metrics are published: https://github.com/apache/kafka/pull/20570/files#diff-a8f919d43ec1cebdb136acf94adfbeb20fef0cda0ad5d29b7010e0186b355d71 |
Hi @Nikita-Shupletsov Thanks for your time checking these changes. 😄 Unfortunately, this PR contains too many changes that I need to clean up, and it is not particularly easy to follow. I am working on some cleanups to make it easier to read. Thank you for pointing out the integration test. If possible, I'll try to make these changes pass after the cleanup. |
sounds good! |
Delete this text and replace it with a detailed description of your change. The
PR title and body will become the squashed commit message.
If you would like to tag individuals, add some commentary, upload images, or
include other supplemental information that should not be part of the eventual
commit message, please use a separate comment.
If applicable, please include a summary of the testing strategy (including
rationale) for the proposed change. Unit and/or integration tests are expected
for any behavior change and system tests should be considered for larger
changes.