-
Notifications
You must be signed in to change notification settings - Fork 14.7k
(WIP) KAFKA-17243:MetadataQuorumCommand describe to include CommittedVoters #20712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TaiJuWu
wants to merge
35
commits into
apache:trunk
Choose a base branch
from
TaiJuWu:committedVoter
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+163
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce committedVoters field in QuorumInfo class - Update KafkaAdminClient to populate committedVoters from partition info - Add getter method for committedVoters in QuorumInfo
- Rename `voterStates` to `currentVoterStates` for clarity - Update all references to use the new name - Add `currentVoterStates()` getter method - Remove unused `voterStates()` method
…ateMachine - Introduce new method `lastVoterSetWithOffset()` in KRaftControlRecordStateMachine - Return a Map.Entry containing the last VoterSet and its corresponding offset - Synchronize access to voterSetHistory for thread safety
…rum API - Add committedVoterStates to LeaderState to track committed voters - Update LeaderState to manage both current and committed voter states - Modify KafkaRaftClient to use new lastVoterSetWithOffset method - Extend RaftUtil.buildDescribeQuorumResponse to include committed voters - Update DescribeQuorum API to support committed voters (version 3)
This reverts commit 91da1a1.
4c48bfc
to
10727b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetadataQuorumCommand and describeMetadataQuorum support returning
committed voter.
The committed voter can come from KRaftControllerStateMachine so
LeaderState extend to include it. Because all offset and voterSet will
be restored in KRaftControllerStateMachine, we can get committed voters
from KRaftControllerStateMachine.