MINOR: Correcting the order of params in share fetch/partition tests #20725
+284
−284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
chia7712
reviewed
Oct 17, 2025
|
|
||
| private MemoryRecords createMemoryRecords(long baseOffset, int numRecords) { | ||
| try (MemoryRecordsBuilder recordsBuilder = memoryRecordsBuilder(numRecords, baseOffset)) { | ||
| try (MemoryRecordsBuilder recordsBuilder = memoryRecordsBuilder(baseOffset, numRecords)) { |
There was a problem hiding this comment.
public static MemoryRecordsBuilder memoryRecordsBuilder(int numOfRecords, long startOffset) {
return memoryRecordsBuilder(ByteBuffer.allocate(1024), numOfRecords, startOffset);
}it seems this change is incorrect.
There was a problem hiding this comment.
Seems I missed pushing the changes in file: ShareFetchTestUtils.java. There were other local changes and missed the file. Pushed now.
| private MemoryRecords createMemoryRecords(Map<Long, Integer> recordsPerOffset) { | ||
| ByteBuffer buffer = ByteBuffer.allocate(1024); | ||
| recordsPerOffset.forEach((offset, numOfRecords) -> memoryRecordsBuilder(buffer, numOfRecords, offset).close()); | ||
| recordsPerOffset.forEach((offset, numOfRecords) -> memoryRecordsBuilder(buffer, offset, numOfRecords).close()); |
There was a problem hiding this comment.
public static MemoryRecordsBuilder memoryRecordsBuilder(ByteBuffer buffer, int numOfRecords, long startOffset) {
MemoryRecordsBuilder builder = MemoryRecords.builder(buffer, Compression.NONE,
TimestampType.CREATE_TIME, startOffset, 2);
for (int i = 0; i < numOfRecords; i++) {
builder.appendWithOffset(startOffset + i, 0L, TestUtils.randomString(10).getBytes(), TestUtils.randomString(10).getBytes());
}
return builder;
}
ditto
There was a problem hiding this comment.
Same, pushed the file.
|
@chia7712 Can you please re-review. |
chia7712
reviewed
Oct 18, 2025
There was a problem hiding this comment.
@apoorvmittal10 thanks for this patch. While this PR does not change every order, that should be fine if all tests pass. However, some comments are now incorrect
| memoryRecords(2, 1).records().forEach(builder::append); | ||
| } | ||
| // Do not include batch from offset 5. And compact batch starting at offset 20. | ||
| try (MemoryRecordsBuilder builder = MemoryRecords.builder(buffer, Compression.NONE, |
There was a problem hiding this comment.
line#7559 needs to be updated too
| fetchAcquiredRecords(sharePartition, memoryRecords(10, 12), 12); | ||
|
|
||
| sharePartition.acknowledge(MEMBER_ID, List.of( | ||
| new ShareAcknowledgementBatch(5, 11, List.of((byte) 2)), |
| MemoryRecords records1 = memoryRecords(3); | ||
| String memberId1 = MEMBER_ID; | ||
| String memberId2 = "member-2"; | ||
|
|
There was a problem hiding this comment.
please take a look at line#7176
| public void testCanAcquireRecordsReturnsTrue() { | ||
| SharePartition sharePartition = SharePartitionBuilder.builder().withState(SharePartitionState.ACTIVE).build(); | ||
|
|
||
| assertEquals(0, sharePartition.startOffset()); |
There was a problem hiding this comment.
please check line#6769 - it has incorrect comment now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating params for share partition tests for readability.