MINOR: Add SanityCheck #21165 [S3599]
#21168
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
Pankraz76
commented
Dec 17, 2025
| ); | ||
| } | ||
|
|
||
| private static boolean matchingTopic(ShareAcknowledgeResponseData.ShareAcknowledgeTopicResponse previousTopic, TopicIdPartition currentTopic) { |
Author
There was a problem hiding this comment.
this now being the only one unused.
Asking to include here to make, or dedicate/extract?
Sanity Check made to be generic and still individual.
| id 'org.openrewrite.rewrite' version '7.22.0' apply false | ||
| id 'org.owasp.dependencycheck' version '12.1.8' | ||
| id 'org.nosphere.apache.rat' version "0.8.1" | ||
| id "io.swagger.core.v3.swagger-gradle-plugin" version "${swaggerVersion}" |
| id 'com.gradleup.shadow' version '8.3.9' apply false | ||
| id 'io.swagger.core.v3.swagger-gradle-plugin' version "${swaggerVersion}" | ||
| id 'org.nosphere.apache.rat' version '0.8.1' | ||
| id 'org.openrewrite.rewrite' version '7.22.0' apply false |
Author
There was a problem hiding this comment.
just wanted to align and give natural order.
Member
There was a problem hiding this comment.
If I read this correctly, org.openrewrite.rewrite is newly added? Others are just reordered.
I am not familiar with this package. Curious to hear from others about it.
Author
There was a problem hiding this comment.
correct.
This versatile SCA tool is already running in checkstyle and spotless.
Highly welcome any feedback, thx.
Pankraz76
force-pushed
the
fix-NoDoubleBraceInitialization-pr
branch
from
47374c7 to
247a78a
Compare
Member
…apache.kafka.openrewrite.SanityCheck` apache#21165 Signed-off-by: Vincent Potucek <[email protected]>
Pankraz76
force-pushed
the
fix-NoDoubleBraceInitialization-pr
branch
from
247a78a to
57eb038
Compare
This was referenced Dec 17, 2025
Pankraz76
pushed a commit
to Pankraz76/kafka
that referenced
this pull request
Dec 18, 2025
…ache#21161 apache#21168 Signed-off-by: Vincent Potucek <[email protected]>
Pankraz76
pushed a commit
to Pankraz76/kafka
that referenced
this pull request
Dec 18, 2025
…ache#21161 apache#21168 Signed-off-by: Vincent Potucek <[email protected]>
Author
|
it seems this pr is related as well: |
Pankraz76
changed the title
NoDoubleBraceInitialization Introduce org.apache.kafka.openrewrite.SanityCheck #21165 SanityCheck#NoDoubleBraceInitialization #21165 [S3599]
Pankraz76
changed the title
SanityCheck#NoDoubleBraceInitialization #21165 [S3599] SanityCheck #21165 [S3599]
Pankraz76
pushed a commit
to Pankraz76/kafka
that referenced
this pull request
Jan 8, 2026
…SPEC-S1488] - https://sonarsource.github.io/rspec/#/rspec/S1488 - https://docs.openrewrite.org/recipes/staticanalysis/inlinevariable Signed-off-by: Vincent Potucek <[email protected]>
Pankraz76
pushed a commit
to Pankraz76/kafka
that referenced
this pull request
Jan 8, 2026
…SPEC-S1488] - https://sonarsource.github.io/rspec/#/rspec/S1488 - https://docs.openrewrite.org/recipes/staticanalysis/inlinevariable Signed-off-by: Vincent Potucek <[email protected]>
Member
Author
|
reopen after enabler: |
Pankraz76
pushed a commit
to Pankraz76/kafka
that referenced
this pull request
Jan 9, 2026
…che#21149 Signed-off-by: Vincent Potucek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MINOR: Add
SanityCheck#21165 [S3599]According to @mjsax:
Apply convention principle for:
https://docs.openrewrite.org/recipes/staticanalysis/nodoublebraceinitialization
Kindly asking, if this is any good?
Thanks for effort given.