chore(storage): remove FindKeyRangeWithPrefix and fix DeleteRange #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
approved these changes
May 30, 2024
mapleFU
reviewed
May 31, 2024
Comment on lines
+381
to
+387
| for (auto iter = s.rbegin(); iter != s.rend(); ++iter) { | ||
| if (*iter != char(0xff)) { | ||
| (*iter)++; | ||
| break; | ||
| } | ||
| } | ||
| return s; |
There was a problem hiding this comment.
should we append a '0x00' if s == return s?
There was a problem hiding this comment.
I think the semantics is different between appending 0x00 and increasing last char by 1.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
FindKeyRangeWithPrefixseems useless since we can always construct a key range quickly, without knowing the exact first key and last key in the range.