-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cron): add support for "*/n" interval cronjob syntax #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinoute
changed the title
Add support for "*/n" interval cronjob syntax
feat(cron): add support for "*/n" interval cronjob syntax
Jun 9, 2024
PragmaTwice
reviewed
Jun 10, 2024
PragmaTwice
reviewed
Jun 10, 2024
PragmaTwice
reviewed
Jun 10, 2024
@PragmaTwice Thanks for your suggestions, I updated the code |
PragmaTwice
reviewed
Jun 10, 2024
PragmaTwice
reviewed
Jun 10, 2024
PragmaTwice
reviewed
Jun 10, 2024
Co-authored-by: Twice <[email protected]>
@PragmaTwice Thanks, updated again the code |
PragmaTwice
reviewed
Jun 11, 2024
PragmaTwice
reviewed
Jun 11, 2024
PragmaTwice
reviewed
Jun 11, 2024
I added more tests for non interval syntax and renamed the |
PragmaTwice
reviewed
Jun 12, 2024
PragmaTwice
approved these changes
Jun 13, 2024
Quality Gate passedIssues Measures |
git-hulk
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently KVRocks only supports integers and * in crontab format. I thought it would be nice to add support for the
*/n
interval syntax. I understand that we can already add multiple crontab entries for the same feature like this:But it would be convenient if we could do something like this instead:
Again, I'm new to C++ so no offense taken if the code provided is not good at all for your standards. The "month" part was a pain to do and I'm not sure about it. I used https://crontab.guru/#0_*_*_*/4_* to calibrate my code/tests for this.