Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port HIVE-27815: Support update numModifiedRows #6639

Closed
wants to merge 2 commits into from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Aug 22, 2024

🔍 Description

Backport apache/hive#4819

Note: it's only the JDBC driver side change, to make it work, we also need to modify the engines.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

We can not test this feature so far because we don't have engine support that. Pass GHA to ensure it breaks nothing.


Checklist 📝

Be nice. Be informative.

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (df8448c) to head (4b3bcd6).
Report is 5 commits behind head on master.

Files Patch % Lines
...a/org/apache/kyuubi/jdbc/hive/KyuubiStatement.java 0.00% 10 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6639   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         680     680           
  Lines       42045   42056   +11     
  Branches     5739    5743    +4     
======================================
- Misses      42045   42056   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan3793 pan3793 requested a review from turboFei August 23, 2024 06:55
@pan3793
Copy link
Member Author

pan3793 commented Aug 26, 2024

interesting error, CI runs at mid-night at UTC timezone, thus failed with

Path does not exist: file:/home/runner/work/kyuubi/kyuubi/kyuubi-server/target/tmp/kyuubi-9be91795-ccaa-4905-b249-8d147597f34f/kyuubi_operation/day=20240825

let me re-trigger it.

@pan3793 pan3793 self-assigned this Aug 26, 2024
@pan3793 pan3793 added this to the v1.10.0 milestone Aug 26, 2024
@pan3793 pan3793 closed this in 2d883e7 Aug 26, 2024
@pan3793
Copy link
Member Author

pan3793 commented Aug 26, 2024

Merged to master

@pan3793
Copy link
Member Author

pan3793 commented Nov 28, 2024

Given this causes significant perf regression(see #6796) and the newly added functionality is not completed, let me revert it first.

pan3793 added a commit that referenced this pull request Nov 28, 2024
pan3793 added a commit that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants