[CI] skip explicitly setting check-latest to false #6768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
kind:infra
wForget
approved these changes
Oct 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6768 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 684 684
Lines 42353 42354 +1
Branches 5775 5776 +1
======================================
- Misses 42353 42354 +1 ☔ View full report in Codecov by Sentry. |
bowenliang123
added a commit
that referenced
this pull request
Oct 22, 2024
# 🔍 Description ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 - skip explicitly set the parameter `check-latest` of Github action `actions/setup-java` to false, which is its default value. - docs: https://github.com/actions/setup-java?tab=readme-ov-file#check-latest ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6768 from bowenliang123/action-java-latest-false. Closes #6768 a0ecd46 [Bowen Liang] update Authored-by: Bowen Liang <[email protected]> Signed-off-by: Bowen Liang <[email protected]> (cherry picked from commit 1d668ea) Signed-off-by: Bowen Liang <[email protected]>
|
Thanks, merged to master (1.10.0) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #
Describe Your Solution 🔧
check-latestof Github actionactions/setup-javato false, which is its default value.Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.