Add metrics for batch pending max elapse time #6829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:server
module:common
module:metrics
kind:documentation
turboFei
force-pushed
the
batch_pending_time
branch
from
acc99b1 to
30eb694
Compare
turboFei
changed the title
turboFei
force-pushed
the
batch_pending_time
branch
from
30eb694 to
1e93dd2
Compare
turboFei
force-pushed
the
batch_pending_time
branch
from
95a8de6 to
6c82970
Compare
turboFei
force-pushed
the
batch_pending_time
branch
from
6c82970 to
1680175
Compare
turboFei
force-pushed
the
batch_pending_time
branch
from
d2a490d to
ab7b6db
Compare
pan3793
reviewed
Dec 2, 2024
| val filter = MetadataFilter( | ||
| sessionType = SessionType.BATCH, | ||
| engineType = batchType, | ||
| username = batchUser, | ||
| state = batchState, | ||
| requestName = batchName, | ||
| createTime = createTime, | ||
| createTime = createTimeFilter, | ||
| endTime = endTime) |
There was a problem hiding this comment.
not related to this PR, but createTime and endTime are confusing, should be minCreateTime and maxEndTime, and say if they are inclusive or exclusive in the comments, with an explanation for specific values
There was a problem hiding this comment.
update: the predication name might be more intuitive if we use greatThanXXX lessThanOrEqualsXXX
There was a problem hiding this comment.
Will address it in another PR
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Dec 2, 2024
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Dec 2, 2024
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala
Outdated
Show resolved
Hide resolved
|
thanks for the comments, will address it today |
turboFei
force-pushed
the
batch_pending_time
branch
2 times, most recently
from
e8aa576 to
d9bc335
Compare
turboFei
force-pushed
the
batch_pending_time
branch
from
d9bc335 to
bf8169a
Compare
pan3793
reviewed
Dec 3, 2024
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
Outdated
Show resolved
Hide resolved
pan3793
approved these changes
Dec 5, 2024
pan3793
pushed a commit
that referenced
this pull request
Dec 5, 2024
### Why are the changes needed? 1. add metrics `kyuubi.operartion.batch_pending_max_elapse` for the batch pending max elapse time, which is helpful for batch health monitoring, and we can send alert if the batch pending elapse time too long 2. For `GET /api/v1/batches` api, limit the max time window for listing batches, which is helpful that, we want to reserve more metadata in kyuubi server end, for example: 90 days, but for list batches, we just want to allow user to search the last 7 days. It is optional. And if `create_time` is specified, order by `create_time` instead of `key_id`. https://github.com/apache/kyuubi/blob/68a6f48da53dd0ad2e20b450a41ca600b8c1e1d2/kyuubi-server/src/main/resources/sql/mysql/metadata-store-schema-1.8.0.mysql.sql#L32 ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #6829 from turboFei/batch_pending_time. Closes #6829 ee4f931 [Wang, Fei] docs bf8169a [Wang, Fei] comments f493a2a [Wang, Fei] new config ab7b6db [Wang, Fei] ut 1680175 [Wang, Fei] in memory session 510a30b [Wang, Fei] batchSearchWindow opt 1e93dd2 [Wang, Fei] save Authored-by: Wang, Fei <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 3167692) Signed-off-by: Cheng Pan <[email protected]>
|
Thanks, merged to master/1.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
kyuubi.operartion.batch_pending_max_elapsefor the batch pending max elapse time, which is helpful for batch health monitoring, and we can send alert if the batch pending elapse time too longGET /api/v1/batchesapi, limit the max time window for listing batches, which is helpful that, we want to reserve more metadata in kyuubi server end, for example: 90 days, but for list batches, we just want to allow user to search the last 7 days. It is optional. And ifcreate_timeis specified, order bycreate_timeinstead ofkey_id.kyuubi/kyuubi-server/src/main/resources/sql/mysql/metadata-store-schema-1.8.0.mysql.sql
Line 32 in 68a6f48
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
No.