Show the FQDN instance in prometheus metrics #6863
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
force-pushed
the
prometheus_label
branch
from
38664ab to
5b8db1e
Compare
turboFei
force-pushed
the
prometheus_label
branch
from
5b8db1e to
17b7007
Compare
turboFei
commented
Dec 25, 2024
| sb.append( | ||
| s"${prefix}{quantile=\"0.99\",type=\"timers\",$instanceLabel} ${snapshot.get99thPercentile()}\n") | ||
| sb.append( | ||
| s"${prefix}{quantile=\"0.999\",type=\"timers\",$instanceLabel} ${snapshot.get999thPercentile()}\n") |
There was a problem hiding this comment.
before, timer example:
# HELP kyuubi_backend_service_execute_statement Generated from Dropwizard metric import (metric=kyuubi.backend_service.execute_statement, type=com.codahale.metrics.Timer)
# TYPE kyuubi_backend_service_execute_statement summary
kyuubi_backend_service_execute_statement{quantile="0.5",} 0.038373501000000004
kyuubi_backend_service_execute_statement{quantile="0.75",} 0.039456969
kyuubi_backend_service_execute_statement{quantile="0.95",} 0.041447420000000006
kyuubi_backend_service_execute_statement{quantile="0.98",} 0.042374208000000003
kyuubi_backend_service_execute_statement{quantile="0.99",} 0.05199264000000001
kyuubi_backend_service_execute_statement{quantile="0.999",} 0.10801610800000001
kyuubi_backend_service_execute_statement_count 815642.0
turboFei
commented
Dec 25, 2024
| } | ||
| } | ||
| registry.getCounters.asScala.foreach { case (k, v) => | ||
| sb.append(s"${normalizeKey(k)}$countersLabel ${v.getCount}\n") |
There was a problem hiding this comment.
Gauge and counter example before:
# HELP kyuubi_connection_opened_b_citrst Generated from Dropwizard metric import (metric=kyuubi.connection.opened.b_citrst, type=com.codahale.metrics.Counter)
# TYPE kyuubi_connection_opened_b_citrst gauge
kyuubi_connection_opened_b_citrst 0.0
turboFei
commented
Dec 25, 2024
| sb.append(s"${prefix}{quantile=\"0.98\",type=\"histograms\",$instanceLabel} ${snapshot.get98thPercentile()}\n") | ||
| sb.append(s"${prefix}{quantile=\"0.99\",type=\"histograms\",$instanceLabel} ${snapshot.get99thPercentile()}\n") | ||
| sb.append(s"${prefix}{quantile=\"0.999\",type=\"histograms\",$instanceLabel} ${snapshot.get999thPercentile()}\n") | ||
| } |
There was a problem hiding this comment.
Example before:
# HELP kyuubi_operation_exec_time_ExecuteStatement_hermesrno_yuanqguo Generated from Dropwizard metric import (metric=kyuubi.operation.exec_time.ExecuteStatement.hermesrno.yuanqguo, type=com.codahale.metrics.Histogram)
# TYPE kyuubi_operation_exec_time_ExecuteStatement_hermesrno_yuanqguo summary
kyuubi_operation_exec_time_ExecuteStatement_hermesrno_yuanqguo{quantile="0.5",} 0.0
kyuubi_operation_exec_time_ExecuteStatement_hermesrno_yuanqguo{quantile="0.75",} 0.0
kyuubi_operation_exec_time_ExecuteStatement_hermesrno_yuanqguo{quantile="0.95",} 0.0
kyuubi_operation_exec_time_ExecuteStatement_hermesrno_yuanqguo{quantile="0.98",} 0.0
kyuubi_operation_exec_time_ExecuteStatement_hermesrno_yuanqguo{quantile="0.99",} 0.0
kyuubi_operation_exec_time_ExecuteStatement_hermesrno_yuanqguo{quantile="0.999",} 0.0
kyuubi_operation_exec_time_ExecuteStatement_hermesrno_yuanqguo_count 1.0
turboFei
commented
Dec 25, 2024
| val prefix = normalizeKey(kv.getKey) | ||
| val meter = kv.getValue | ||
| sb.append(s"${prefix}$metersLabel ${meter.getCount}\n") | ||
| sb.append(s"${prefix}_MeanRate$metersLabel ${meter.getMeanRate}\n") |
There was a problem hiding this comment.
Meter example before
# HELP kyuubi_operation_state_initialized_total Generated from Dropwizard metric import (metric=kyuubi.operation.state.initialized, type=com.codahale.metrics.Meter)
# TYPE kyuubi_operation_state_initialized_total counter
kyuubi_operation_state_initialized_total 1371702.0
fcee248 to
02722bf
Compare
turboFei
force-pushed
the
prometheus_label
branch
from
02722bf to
4239594
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The instance list shown in the new added grafana dashboard is not human readable.
In this PR, I try to add instance label with FQDN in the prometheus metrics.
How was this patch tested?
I will check the metrics for before and after to keep the compatibility.
Was this patch authored or co-authored using generative AI tooling?