Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading commons-collections to commons-collections4 #6893

Closed
wants to merge 1 commit into from

Conversation

avishnus
Copy link
Contributor

Why are the changes needed?

commons-collections has reached EOL. Need to migrate to commons-collections4

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

No

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (fff1841) to head (0de6b5b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6893   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         688     688           
  Lines       42590   42590           
  Branches     5805    5805           
======================================
  Misses      42590   42590           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan3793
Copy link
Member

pan3793 commented Jan 21, 2025

This won't work.

Kyuubi itself does not use commons-collections but the supported engines like Hive do.

@pan3793
Copy link
Member

pan3793 commented Jan 21, 2025

close as proposed change is invalid

@pan3793 pan3793 closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants