Fix DNS driver API inconsistencies

docs/dns/_supported_methods.rst

@@ -26,7 +26,6 @@ Provider          list zones list records create zone update zone create record
 `Route53 DNS`_    yes        yes          yes         no          yes           yes           yes         yes          
 `Vultr DNS`_      yes        yes          yes         no          yes           yes           yes         yes          
 `World Wide DNS`_ yes        yes          yes         yes         yes           yes           yes         yes          
-`Zerigo DNS`_     yes        yes          yes         yes         yes           yes           yes         yes          
 `Zonomi DNS`_     yes        yes          yes         no          yes           no            yes         yes          
 ================= ========== ============ =========== =========== ============= ============= =========== =============
 
@@ -53,5 +52,4 @@ Provider          list zones list records create zone update zone create record
 .. _`Route53 DNS`: http://aws.amazon.com/route53/
 .. _`Vultr DNS`: https://www.vultr.com
 .. _`World Wide DNS`: https://www.worldwidedns.net/
-.. _`Zerigo DNS`: http://www.zerigo.com/
 .. _`Zonomi DNS`: https://zonomi.com

docs/dns/_supported_providers.rst

@@ -26,7 +26,6 @@ Provider          Documentation                             Provider Constant Su
 `Route53 DNS`_                                              ROUTE53           single region driver :mod:`libcloud.dns.drivers.route53`      :class:`Route53DNSDriver`     
 `Vultr DNS`_      :doc:`Click </dns/drivers/vultr>`         VULTR             single region driver :mod:`libcloud.dns.drivers.vultr`        :class:`VultrDNSDriver`       
 `World Wide DNS`_ :doc:`Click </dns/drivers/worldwidedns>`  WORLDWIDEDNS      single region driver :mod:`libcloud.dns.drivers.worldwidedns` :class:`WorldWideDNSDriver`   
-`Zerigo DNS`_                                               ZERIGO            single region driver :mod:`libcloud.dns.drivers.zerigo`       :class:`ZerigoDNSDriver`      
 `Zonomi DNS`_     :doc:`Click </dns/drivers/zonomi>`        ZONOMI            single region driver :mod:`libcloud.dns.drivers.zonomi`       :class:`ZonomiDNSDriver`      
 ================= ========================================= ================= ==================== ======================================== ==============================
 
@@ -53,5 +52,4 @@ Provider          Documentation                             Provider Constant Su
 .. _`Route53 DNS`: http://aws.amazon.com/route53/
 .. _`Vultr DNS`: https://www.vultr.com
 .. _`World Wide DNS`: https://www.worldwidedns.net/
-.. _`Zerigo DNS`: http://www.zerigo.com/
 .. _`Zonomi DNS`: https://zonomi.com

libcloud/common/nsone.py

@@ -24,10 +24,10 @@
 
 
 class NsOneResponse(JsonResponse):
-    errors = []  # type: List[Dict]
-    objects = []  # type: List[Dict]
-
     def __init__(self, response, connection):
+        self.errors = []  # type: List[Dict]
+        self.objects = []  # type: List[Dict]
+
         super().__init__(response=response, connection=connection)
         self.errors, self.objects = self.parse_body_and_errors()
         if not self.success():

libcloud/common/vultr.py

@@ -21,9 +21,7 @@
 
 __all__ = [
     "API_HOST",
-    "VultrConnection",
     "VultrException",
-    "VultrResponse",
     "DEFAULT_API_VERSION",
     "VultrResponseV2",
     "VultrConnectionV2",
@@ -37,93 +35,6 @@
 DEFAULT_API_VERSION = "2"
 
 
-class VultrResponse(JsonResponse):
-    objects = None
-    error_dict = {}  # type: Dict[str, str]
-    errors = None
-    ERROR_CODE_MAP = {
-        400: "Invalid API location. Check the URL that you are using.",
-        403: "Invalid or missing API key. Check that your API key is present"
-        + " and matches your assigned key.",
-        405: "Invalid HTTP method. Check that the method (POST|GET) matches"
-        + " what the documentation indicates.",
-        412: "Request failed. Check the response body for a more detailed" + " description.",
-        500: "Internal server error. Try again at a later time.",
-        503: "Rate limit hit. API requests are limited to an average of 1/s."
-        + " Try your request again later.",
-    }
-
-    def __init__(self, response, connection):
-        self.errors = []
-        super().__init__(response=response, connection=connection)
-        self.objects, self.errors = self.parse_body_and_errors()
-        if not self.success():
-            raise self._make_excp(self.errors[0])
-
-    def parse_body_and_errors(self):
-        """
-        Returns JSON data in a python list.
-        """
-        json_objects = []
-        errors = []
-
-        if self.status in self.ERROR_CODE_MAP:
-            self.error_dict["ERRORCODE"] = self.status
-            self.error_dict["ERRORMESSAGE"] = self.ERROR_CODE_MAP[self.status]
-            errors.append(self.error_dict)
-
-        js = super().parse_body()
-        if isinstance(js, dict):
-            js = [js]
-
-        json_objects.append(js)
-
-        return (json_objects, errors)
-
-    def _make_excp(self, error):
-        """
-        Convert API error to a VultrException instance
-        """
-
-        return VultrException(error["ERRORCODE"], error["ERRORMESSAGE"])
-
-    def success(self):
-        return len(self.errors) == 0
-
-
-class VultrConnection(ConnectionKey):
-    """
-    A connection to the Vultr API
-    """
-
-    host = API_HOST
-    responseCls = VultrResponse
-
-    def add_default_params(self, params):
-        """
-        Returns default params such as api_key which is
-        needed to perform an action.Returns a dictionary.
-        Example:/v1/server/upgrade_plan?api_key=self.key
-        """
-        params["api_key"] = self.key
-
-        return params
-
-    def add_default_headers(self, headers):
-        """
-        Returns default headers such as content-type.
-        Returns a dictionary.
-        """
-        headers["Content-Type"] = "application/x-www-form-urlencoded"
-        headers["Accept"] = "text/plain"
-
-        return headers
-
-    def set_path(self):
-        self.path = "/v/"
-        return self.path
-
-
 class VultrResponseV2(JsonResponse):
     valid_response_codes = [
         httplib.OK,