Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to remove the HierarchyEventListener #234

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Add a way to remove the HierarchyEventListener #234

merged 2 commits into from
Jul 28, 2023

Conversation

rm5248
Copy link
Contributor

@rm5248 rm5248 commented Jul 17, 2023

See #233

@rm5248
Copy link
Contributor Author

rm5248 commented Jul 21, 2023

Note: ABI failure is due to adding new virtual function(see: https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B). The important note:

You cannot:
Add new virtual functions for any reason, even to leaf classes, if the class is intended to remain binary compatible on Windows.

So I think we will just have to add this to only the Hierarchy class for now, ignoring the parent LoggerRepository. Whenever we bump the ABI we can fix this.

@rm5248 rm5248 merged commit de4bc7d into master Jul 28, 2023
24 checks passed
@rm5248 rm5248 deleted the remove-hierarchy-listener branch July 28, 2023 13:43
@rm5248 rm5248 mentioned this pull request Jul 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rm5248