Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DisposeAfterSuite/DisposeAfterTest functionaltiy to the test framework #1094

Open
1 task done
NightOwl888 opened this issue Jan 12, 2025 · 0 comments · May be fixed by #1096
Open
1 task done

Add DisposeAfterSuite/DisposeAfterTest functionaltiy to the test framework #1094

NightOwl888 opened this issue Jan 12, 2025 · 0 comments · May be fixed by #1096
Assignees
Labels

Comments

@NightOwl888
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Task description

In Lucene, there were closeAfterTest() and closeAfterSuite() methods on LuceneTestCase that users can use to ensure resources are cleaned up.

The closeAfterSuite() method in Lucene registers a wrapper class for each Directory that is created, which does a check globally to ensure every Directory is closed. We should implement this to help ensure we aren't leaking any Directory instances in tests.

This also depends on the TestRuleMarkFailure feature, but that is a duplicate of the RuleState enum that already exists in NUnit so it is best to leverage that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant