Added DisposeAfterSuite/DisposeAfterTest feature to test framework #1096
+333
−265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st() and DisposeAfterSuite() and removed TestMarkerFailure and SuiteMarkerFailure, since this info is already available through NUnit's TestExecutionContext.
…omments to indicate why we don't need this class in .NET. It is not sensible to have it because result state is already tracked by NUnit and is context sensitive.
…Writer, and IndexReader were not being disposed in any of these tests. Not closing the wrapped reader was being detected by the test framework as a problem and casing it to fail the test run, so added using statements to each of these instances so they will be cleaned up at the end of each test.
… caused any failure, so we can debug more easily.
…to ignore the fact that the LineDocsFile is not being deleted.
…domizedtesting and is not exposed publicly by Lucene.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added DisposeAfterSuite/DisposeAfterTest feature to test framework
Fixes #1094
Description
This adds the
LuceneTestCase.DisposeAfterTest()andLuceneTestCase.DisposeAfterSuite()methods to the test framework that exist in Lucene 4.8.0.It also removes the
LuceneTestCase.SuiteFailureMarkerproperty that wasn't implemented. NUnit already tracks the result state of the tests inNUnit.Framework.Internal.TestExectionContext.CurrentContext.TestResult.ResultStateandNUnit.Framework.TestContext.CurrentContext.Result.Outcomein a context-sensitive and thread safe manner, so there is no need to reinvent the wheel with this. For the same reason, we don't need theTestFailureMarkerproperty orTestRuleMarkFailureclass, which are all part of this feature.The new feature also revealed that there were some directories that were not being disposed in
Lucene.Net.Tests.Groupingwhich were also addressed.For some reason
TestFsts.TestRealTerms()does not reliably cleanup its line file docs temp file on Windows, so this adds the[SuppressTempFileChecks]attribute to suppress the issue when it happens (for now). At some point we should have a look at this, but it is not a blocker for the release.