Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install to remind new mac user account on which shell profile to modify #312

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion content/markdown/install.md.vm
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ tar xzvf apache-maven-${currentStableVersion}-bin.tar.gz
Alternatively use your preferred archive extraction tool.

* Add the `bin` directory of the created directory `apache-maven-${currentStableVersion}` to
the `PATH` environment variable
the `PATH` environment variable.

* Confirm with `mvn -v` in a new shell. The result should look similar to

Expand Down Expand Up @@ -70,6 +70,7 @@ The same dialog can be used to set `JAVA_HOME` to the location of your JDK, e.g.

Unix-based Operating System (Linux, Solaris and Mac OS X) Tips
-----
Apple sets the zsh shell as the default for any new user account that is created in macOS Catalina(10.15.7) or later. Thus, `.zprofile` is the startup file when you open up a terminal. You would need to modify `PATH` environment variable in `.zprofile` instead of `.bash_profile`. But if you upgraded your macOS from an earlier version, you can still add environment variable to `.bash_profile`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is worth mentioning but there are more than just two shells. Can this be rewritten in a more shell independent fashion?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd even drop this because it may fall out of date or is too system and shell specific. If someone isn't able to set variabled permanently, change job.


* Check environment variable value

Expand Down