-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-8097] Outline the two different ways to reference a dependency #529
base: master
Are you sure you want to change the base?
Conversation
(with a related artifact handler)
827787d
to
87229d3
Compare
different extension and a classifier. The type often corresponds to the packaging used, though this is | ||
also not always the case. Some examples are <<<jar>>>, <<<ejb-client>>> and <<<test-jar>>>: | ||
see {{{/ref/current/maven-core/artifact-handlers.html}default artifact handlers}} for a list. New types can be | ||
defined by plugins that set <<<extensions>>> to true, so this is not a complete list. | ||
|
||
In case there is an artifact handler defined there are <two> different ways of referencing the same dependency: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this very much mixed up and not quite comprehensive. @hboutemy
Issues:
- by removal of "filename", the term "extension" is suddenly changing it's meaning (maven extension? this was my first thought while trying to comprehend the message)
- did you maybe mix up the "former and latter"?
- I find this very confusing all in all. Type is type, why do you want to mixin here file extension?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by removal of "filename", the term "extension" is suddenly changing it's meaning (maven extension? this was my first thought while trying to comprehend the message)
you kind of said the opposite in apache/maven#1466 (comment). This is the extension of the artifact which is not necessarily the extension of the filename!
The depensency extension is told by type. Deoendency is never "anywhere on disk", it may come from repo only.
or in apache/maven#1466 (comment)
It is artifact that you need to inspect, not the backing file.
yes, good catch will fix.
I find this very confusing all in all. Type is type, why do you want to mixin here file extension
First of all, there was a mention of file extension before this PR, with this PR I only refer to artifact extension (do you find this part confusing???). This PR rather clarifies that there may be two ways to reference the same artifact, examples:
-
vs.
<dependency> <groupId>org.project</groupId> <artifactId>reusable-test-support</artifactId> <version>1.0</version> <classifier>tests</classifier> </dependency>
<dependency> <groupId>org.project</groupId> <artifactId>reusable-test-support</artifactId> <version>1.0</version> <type>test-jar</type> </dependency>
-
vs.
<dependency> <groupId>org.project</groupId> <artifactId>my-osgi-bundle</artifactId> <version>1.0</version> </dependency>
<dependency> <groupId>org.project</groupId> <artifactId>my-osgi-bundle</artifactId> <version>1.0</version> <type>bundle</type> <!-- defined by artifact handler in maven-bundle-plugin --> </dependency>
-
vs.
<dependency> <groupId>org.project</groupId> <artifactId>my-content-package</artifactId> <version>1.0</version> <type>zip</type> </dependency>
<dependency> <groupId>org.project</groupId> <artifactId>my-content-package</artifactId> <version>1.0</version> <type>content-package</type> <!-- defined by artifact handler in filevault-package-maven-plugin --> </dependency>
Please be more concise with your criticism so that I am able to address it.
(with a related artifact handler)