Skip to content

Conversation

@Frawless
Copy link
Contributor

This reverts commit 4a47a1c (#3194). We agreed that we will revert this change and put it into #3200 as one PR/commit

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@olamy
Copy link
Member

olamy commented Oct 30, 2025

we can make it simple and just merge #3200

@Tibor17
Copy link
Contributor

Tibor17 commented Nov 1, 2025

@slachiewicz Hi Slawomir. I assigned it to both of us. We can start making a review if you like.

@Tibor17
Copy link
Contributor

Tibor17 commented Nov 1, 2025

we can make it simple and just merge #3200

Actually, these are not two PRs nothing but one. The reason is that the tests uncovered that the previous commit was wrong. It would be hard for someone to imaging two commits as one if the history is analyzed, so therefore it should be really one commit.

@olamy
Copy link
Member

olamy commented Nov 2, 2025

We cannot rewrite history of master. So we have to live with it.

Just KISS rather than adding even more complexity to history by adding even more commits
Just a comment telling this is an IT for commit xyz and that's it done.
No need to make things more complicated than really needed and never have this merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants