-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WAGON-632] Java 8 #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this to happen master needs to be moved to 4.0.0-M1-SNAPSHOT and then this issue assigned to it.
Would it be possible to replace the httpcomponent dependencies by the classes from the |
This can be a separate module which someone needs to write. |
LGTM @elharo |
Tests have not passed. @michael-o are you OK with this now? |
Yes |
Let me see if I can get the tests to pass |
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu Co-authored-by: Moderne <[email protected]>
#93 might render this moot |
@slachiewicz You can merge this if you like once @michael-o dismisses the requested change. However if you prefer to simply merge #93 and close this PR, I think that works too. |
implicitly fixed by parent pom update https://issues.apache.org/jira/browse/WAGON-634 |
If there's a reason we can't move to Java 8, we can perhaps use Files.copy instead of plexus to copy the directory in FileWagon. Might want to do that anyway. Bugs there seem to be at the root of more than one CI failure.