Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WAGON-632] Java 8 #89

Closed
wants to merge 3 commits into from
Closed

[WAGON-632] Java 8 #89

wants to merge 3 commits into from

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Apr 23, 2023

If there's a reason we can't move to Java 8, we can perhaps use Files.copy instead of plexus to copy the directory in FileWagon. Might want to do that anyway. Bugs there seem to be at the root of more than one CI failure.

@elharo elharo changed the title Java 8 [WAGON-632] Java 8 Apr 23, 2023
@elharo elharo requested a review from michael-o April 23, 2023 14:22
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this to happen master needs to be moved to 4.0.0-M1-SNAPSHOT and then this issue assigned to it.

@HannesWell
Copy link

For this to happen master needs to be moved to 4.0.0-M1-SNAPSHOT and then this issue assigned to it.

Would it be possible to replace the httpcomponent dependencies by the classes from the java.net.http packages which was added in Java-11? If yes, would it then be an option to even go to Java-11?

@michael-o
Copy link
Member

For this to happen master needs to be moved to 4.0.0-M1-SNAPSHOT and then this issue assigned to it.

Would it be possible to replace the httpcomponent dependencies by the classes from the java.net.http packages which was added in Java-11? If yes, would it then be an option to even go to Java-11?

This can be a separate module which someone needs to write.

@slachiewicz
Copy link
Member

LGTM @elharo

@elharo
Copy link
Contributor Author

elharo commented Oct 3, 2023

Tests have not passed.

@michael-o are you OK with this now?

@michael-o
Copy link
Member

Tests have not passed.

@michael-o are you OK with this now?

Yes

@elharo
Copy link
Contributor Author

elharo commented Oct 3, 2023

Let me see if I can get the tests to pass

@elharo
Copy link
Contributor Author

elharo commented Oct 3, 2023

#93 might render this moot

@elharo
Copy link
Contributor Author

elharo commented Oct 3, 2023

@slachiewicz You can merge this if you like once @michael-o dismisses the requested change. However if you prefer to simply merge #93 and close this PR, I think that works too.

@slachiewicz
Copy link
Member

implicitly fixed by parent pom update https://issues.apache.org/jira/browse/WAGON-634

@slachiewicz slachiewicz added the dependencies Pull requests that update a dependency file label Oct 21, 2023
@asfgit asfgit deleted the java8 branch March 31, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants