[prone] Add `UnusedVariable` #11284

Pankraz76 · 2025-10-16T13:24:38Z

Following this checklist to help us incorporate your
contribution quickly and easily:

Your pull request should address just one issue, without pulling in other changes.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
Run mvn verify to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.

enabler for:

[prone] Add UnusedVariable maven-parent#508

related to:

gnodet

Can you explain how you found those issues, as some of them are just plain wrong. It also contains lots of unrelated changes.

pom.xml

Pankraz76 · 2025-10-16T14:27:53Z

Can you explain how you found those issues, as some of them are just plain wrong. It also contains lots of unrelated changes.

updated to something simple like unused variable. Direct return is something to consider later on as in this case its quite "complex".

api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java

impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelObjectPool.java

Pankraz76

2 ct.

impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSettingsBuilder.java

api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java

impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelObjectPool.java

gnodet · 2025-10-16T15:47:46Z

impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSettingsBuilder.java

-            src = Interpolator.chain(userProperties::get, systemProperties::get);
-        }
-        return new DefSettingsTransformer(value -> value != null ? interpolator.interpolate(value, src) : null)
+    private Settings interpolate(Settings settings, SettingsBuilderRequest request) {


Once again, those are not unused variables. These are intermediary results.
Your refactoring hinders readability.

ppl wondering just like the SCA why its unused or ignored. Having it named accordingly or removed seems to be the best practise in order to turn the questions into answers, as history is mystery.

ppl wondering just like the SCA why its unused or ignored. Having it named accordingly or removed seems to be the best practise in order to turn the questions into answers, as history is mystery.

best practice is to understand what you are refactoring instead of blindly trusting tools/AI

One could argue that "understanding" is a complex goal for this codebase. The presence of incorrect, ignored, and unused segments suggests that the original intent has become obscured over time. It's likely the logic was once valid, but that context has been lost.

The system continues to operate, but its current behavior appears disconnected from its actual purpose, seemingly functioning through emergent coincidence rather than by explicit design (no unused stuff dangling around).

In these situations, static code analysis becomes a valuable tool for reconstructing the rationale behind the code. As team members move on, institutional knowledge fades, and manual auditing does not scale effectively.

From my perspective, comprehending the full scope is challenging. For instance, the purpose of an unused field isn't clear, requiring me to hypothesize about its original function.

Ideally, code should narrate its purpose like a coherent story, with each line building upon the last. Gaps in this narrative—such as unused components or logical inconsistencies—highlight areas where the underlying purpose has been lost. While there may be valid, albeit hidden, reasons for these anomalies, the process of understanding involves methodically converting these open questions into resolved answers to piece together the complete picture.

pom.xml

impl/maven-xml/src/main/java/org/apache/maven/internal/xml/XmlNodeImpl.java

.mvn/jvm.config

api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java

compat/maven-model/src/test/java/org/apache/maven/model/v4/ModelXmlTest.java

impl/maven-xml/src/main/java/org/apache/maven/internal/xml/XmlNodeImpl.java

api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java

Pankraz76

public by default.

api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java

gnodet

This PR has, once again, derailed.
It contains changes which have nothing in common.
Please split PR:

one for the """ string blocks, but maybe look at the whole codebase where it makes sense
one for XmlNode.toString refactoring
one for removing unused variables (but without any other refactoring)

api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java

api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlService.java

api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java

impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelObjectPool.java

Pankraz76 mentioned this pull request Oct 16, 2025

[prone] Add UnusedVariable apache/maven-parent#508

Open

gnodet requested changes Oct 16, 2025

View reviewed changes

Pankraz76 force-pushed the prone branch from b860021 to d26a7aa Compare October 16, 2025 14:25

Pankraz76 changed the title ~~[prone] Add DirectReturn~~ [prone] Add UnusedVariable Oct 16, 2025

Pankraz76 commented Oct 16, 2025

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

Pankraz76 requested a review from gnodet October 16, 2025 14:28

Pankraz76 marked this pull request as ready for review October 16, 2025 14:28

Pankraz76 commented Oct 16, 2025

View reviewed changes

Pankraz76 force-pushed the prone branch from d26a7aa to 6645912 Compare October 16, 2025 14:49

Pankraz76 commented Oct 16, 2025

View reviewed changes

impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSettingsBuilder.java Show resolved Hide resolved

impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSettingsBuilder.java Outdated Show resolved Hide resolved

gnodet requested changes Oct 16, 2025

View reviewed changes

Pankraz76 force-pushed the prone branch 2 times, most recently from dfa71eb to 9b9f1c6 Compare October 16, 2025 16:20

Pankraz76 commented Oct 16, 2025

View reviewed changes

api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java Show resolved Hide resolved

compat/maven-model/src/test/java/org/apache/maven/model/v4/ModelXmlTest.java Outdated Show resolved Hide resolved

Pankraz76 requested a review from gnodet October 16, 2025 16:40

Pankraz76 force-pushed the prone branch 2 times, most recently from 9c45a03 to 80c922b Compare October 16, 2025 17:40

Pankraz76 commented Oct 16, 2025

View reviewed changes

api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java Show resolved Hide resolved

api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java Show resolved Hide resolved

api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java Show resolved Hide resolved

Pankraz76 marked this pull request as draft October 16, 2025 17:45

gnodet requested changes Oct 17, 2025

View reviewed changes

Pankraz76 commented Oct 17, 2025

View reviewed changes

Pankraz76 force-pushed the prone branch from faea901 to 8e5e15e Compare October 17, 2025 08:00

Pankraz76 requested review from Bukama and gnodet October 17, 2025 08:01

Pankraz76 marked this pull request as ready for review October 17, 2025 08:18

Pankraz76 force-pushed the prone branch from 8e5e15e to 0c15316 Compare October 17, 2025 08:30

gnodet reviewed Oct 17, 2025

View reviewed changes

impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelObjectPool.java Outdated Show resolved Hide resolved

Pankraz76 force-pushed the prone branch from 0c15316 to 40bd367 Compare October 17, 2025 09:27

Pankraz76 requested a review from gnodet October 17, 2025 09:29

[prone] Add UnusedVariable

591b5d4

Pankraz76 force-pushed the prone branch from 40bd367 to 591b5d4 Compare October 17, 2025 11:47

Pankraz76 commented Oct 17, 2025

View reviewed changes

impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelObjectPool.java Show resolved Hide resolved

[prone] Add UnusedVariable #11284

Are you sure you want to change the base?

[prone] Add UnusedVariable #11284

Uh oh!

Conversation

Pankraz76 commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gnodet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Pankraz76 commented Oct 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pankraz76 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gnodet Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Pankraz76 Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Bukama Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Pankraz76 Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pankraz76 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gnodet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[prone] Add `UnusedVariable` #11284

[prone] Add `UnusedVariable` #11284

Pankraz76 commented Oct 16, 2025 •

edited

Loading

Pankraz76 Oct 17, 2025 •

edited

Loading