[MNG-8451] Core inject depMgt for plugin resolution #2000
Conversation
|
This works cool, but breaks https://issues.apache.org/jira/browse/MNG-5783 |
| .setVersion(managedDep.getArtifact().getVersion())); | ||
| } | ||
| // align scope | ||
| pluginDep = pluginDep.setScope(managedDep.getScope()); |
There was a problem hiding this comment.
Should we flag them as system scope ?
There was a problem hiding this comment.
... to avoid downloading the jars ?
There was a problem hiding this comment.
Yes, but there is more to this PR, it breaks https://issues.apache.org/jira/browse/MNG-5783 We need to implement the proposed fix in refd issue (real classpath vs ${plugin.artifacts}).
There was a problem hiding this comment.
Former contains plugin stuff + maven core imported (as one), while latter should contain all JARs
The fix was implemented in b7088a3 AFAIK. This may be something slightly different. |
|
Resolve #9404 |
3 participants
Maven Core injects "own provided" artifacts when resolving plugins, instead to let the resolve and then just leave out from the classpath, this makes much less downloads happening.
Example of effects of this PR: Rebuilding Maven master with empty local repository, and after the build:
(this PR basically makes unnecessary to set "maven core dependencies to provided" anymore, as it will NOT download those unused versions, given core is providing itself instead)
Note: Maven master sports "quite fresh" (and aligned) plugins, and almost all are fixed re "provided" scope, hence this difference is not big, but it would be much more visible on some build using "higher range" of non aligned plugins.
https://issues.apache.org/jira/browse/MNG-8451