[MNG-8587] mvnsh navigation #2117
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ability to navigate on disk --- https://issues.apache.org/jira/browse/MNG-8587
|
@gnodet |
gnodet
reviewed
Feb 20, 2025
|
|
||
| public void changeDirectory(String seg) { | ||
| requireNonNull(seg, "seg"); | ||
| if ("..".equals(seg)) { |
There was a problem hiding this comment.
I don't the point for this specific test.
What if you cd ../., that would be the same ?
Also directory.resolve("..") should work, so I don't get why we'd need this branch.
gnodet
reviewed
Feb 20, 2025
|
|
||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| public class Directory implements Supplier<Path>, Function<String, Path> { |
There was a problem hiding this comment.
That looks overkill to me. Why do we use Function<String, Path> instead of just a Path btw ?
And have a non final Path field for the cwd ?
It seems to create a new API on top of the Path API, but not sure what the value is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to navigate on disk
https://issues.apache.org/jira/browse/MNG-8587