Skip to content

Commit

Permalink
CI: build and test on JDK 24-ea
Browse files Browse the repository at this point in the history
 - java hints job remains on 23 and has to wait for nb-javac 24
 - bump CV tests from JDK 22 to 23
 - minor cleanup
  • Loading branch information
mbien committed Nov 17, 2024
1 parent 7a33387 commit c9c954d
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 20 deletions.
29 changes: 11 additions & 18 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ jobs:
timeout-minutes: 40
strategy:
matrix:
java: [ '17', '21', '23' ]
java: [ '17', '21', '24-ea' ]
exclude:
- java: ${{ github.event_name == 'pull_request' && 'nothing' || '21' }}
fail-fast: false
Expand Down Expand Up @@ -229,7 +229,7 @@ jobs:
java: [ 17 ]
include:
- os: ubuntu-latest
java: 22
java: 23
fail-fast: false
steps:

Expand Down Expand Up @@ -416,30 +416,23 @@ jobs:
- name: Build nbms
run: ant $OPTS build-nbms

# runs only in PRs if requested; ~18 min
- name: Build all Tests
if: env.test_tests == 'true' && github.event_name == 'pull_request' && success()
run: ant -quiet -Dcluster.config=$CLUSTER_CONFIG test -Dtest.includes=NoTestsJustBuild

# 13-14 min for javadoc; JDK version must be synced with nb-javac
- name: Set up JDK 23 for javadoc
- name: Set up JDK 24-ea for javadoc
if: env.test_javadoc == 'true' && success()
uses: actions/setup-java@v4
with:
java-version: 23
java-version: 24-ea
distribution: ${{ env.DEFAULT_JAVA_DISTRIBUTION }}

- name: Build javadoc
if: env.test_javadoc == 'true' && success()
run: ant $OPTS build-javadoc

- name: Set up JDK ${{ matrix.java }}
if: env.test_javadoc == 'true' && success()
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java }}
distribution: ${{ env.DEFAULT_JAVA_DISTRIBUTION }}

# runs only in PRs if requested; ~18 min
- name: Build all Tests
if: env.test_tests == 'true' && github.event_name == 'pull_request' && success()
run: ant -quiet -Dcluster.config=$CLUSTER_CONFIG test -Dtest.includes=NoTestsJustBuild

- name: Create Test Summary
uses: test-summary/action@v2
if: failure()
Expand Down Expand Up @@ -834,7 +827,7 @@ jobs:
timeout-minutes: 50
strategy:
matrix:
java: [ '17', '21', '23' ]
java: [ '17', '21', '24-ea' ]
exclude:
- java: ${{ github.event_name == 'pull_request' && 'nothing' || '21' }}
fail-fast: false
Expand Down Expand Up @@ -1494,7 +1487,7 @@ jobs:
timeout-minutes: 60
strategy:
matrix:
java: [ '17', '21', '23' ]
java: [ '17', '21', '24-ea' ]
exclude:
- java: ${{ github.event_name == 'pull_request' && 'nothing' || '21' }}
fail-fast: false
Expand Down
2 changes: 1 addition & 1 deletion ide/ide.kit/nbproject/project.properties
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,5 @@ test.jms.flags=\
--add-opens=java.desktop/javax.swing.plaf.synth=ALL-UNNAMED \
--add-opens=java.desktop/javax.swing.text=ALL-UNNAMED \
--add-opens=java.desktop/sun.awt=ALL-UNNAMED \
--add-modules=jdk.jdwp.agent,jdk.attach,jdk.jdi,jdk.jshell,java.compiler,jdk.compiler,jdk.management,jdk.unsupported,jdk.internal.le,jdk.internal.ed,jdk.internal.opt,jdk.internal.jvmstat \
--add-modules=java.compiler \
--add-exports=jdk.jdi/com.sun.jdi=ALL-UNNAMED
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ public void testLockFile() throws IOException {
expectedCount++;
// sun.awt.PlatformGraphicsInfo.getDefaultHeadlessProperty probes a .so or .dylib
// Runtime.version().feature() > 18
if (Integer.parseInt(System.getProperty("java.version").split("\\.")[0]) > 18) {
if (Integer.parseInt(System.getProperty("java.version").split("\\.")[0].split("-")[0]) > 18) {
expectedCount++;
}
}
Expand Down

0 comments on commit c9c954d

Please sign in to comment.