LSP client stops working on file after renaming it #7829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasblaesing
added
LSP
The LSP protocol requires that when a file is renamed the client signals this to the server by sending a didClose for the old location and after that a didOpen with the new location. The change assumes, that the IDE always goes through the DataObject to issue the rename/move. Changes through the raw FileObject are not tracked. Closes: apache#7806
matthiasblaesing
force-pushed
the
lsp_rename
branch
from
17bf758
to
cb3a152
Compare
|
Reverted to draft. This needs another iteration after merging the changes to the initialization order. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LSP protocol requires that when a file is renamed the client signals this to the server by sending a didClose for the old location and after that a didOpen with the new location.
The change assumes, that the IDE always goes through the DataObject to issue the rename/move. Changes through the raw FileObject are not tracked.
Closes: #7806