Do not break additional DocumentFilters #7903
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
added
Java
sdedic
force-pushed
the
lsp/document-filter
branch
from
2b4a688
to
9b75397
Compare
dbalek
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves behaviour of
CloneableEditorSupportin that it will not break additionalDocumentFilters which may be attached to the AbstractDocument.If a plugin registers a filter for a document, the
CloneableEditorSupportwill erase that filter on document's reload, basically at some unexpected and uncontrolled point. This PR changes the impl so it will not remove the DocumentFilter which would unset the client's DocumentFilter and breaks the pass-through chain), but rather disables it.When the document is listened on again, and it's the same document (!) as the existing filter works with, the filter is re-enabled.
If the document reference changes, a new filter is created; the user must detect that and restore its own filter as the old Document is gone. This should happen mainly if the Document expires and is garbage-collected and is loaded again.