Repository navigation
Simple implementation of LSP protocol shutdown request and exit notification handlers - #8770
Merged
Merged
Conversation
…ication handlers.
lahodaj
approved these changes
Sep 1, 2025
lahodaj
left a comment
Contributor
There was a problem hiding this comment.
Looks reasonable to me. I was thinking if using something like AtomicBoolean would be safer, but I think the dispatch is done in one thread only, so plain boolean is probably OK.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes related to Netbeans Java Language Server
Context
About the changes made
Shutdown Requesthandler and theExit Notificationhandler implementedNote
As per the LSP Spec about Shutdown Request the language server should respond with
Invalid Requesterror post receiving the shutdown request . That can be done in the future if required but has been deferred for now to keep this change simple .