Skip to content

JSF: Add an hint for duplicate attributes on faces tags - #9699

Merged
NicolaIsotta merged 1 commit into
apache:masterfrom
NicolaIsotta:jsf-duplicate-attributes
Oct 13, 2026
Merged

NicolaIsotta merged 1 commit into
apache:masterfrom
NicolaIsotta:jsf-duplicate-attributes

Conversation

@NicolaIsotta

Copy link
Copy Markdown
Contributor
  • add a new duplicate attribute hint to existing ComponentUsagesChecker class
  • minor refactors/optimization to the class
  • add tests

The reason:

  • duplicated attributes are runtime errors (facelets files are parsed with SAX)
  • declared attributes are already checked so the new hint was pretty cheap

Screenshot:
image


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

LLMs, Commit messages and PR description:

  • Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.
  • LLM assisted commits should be attributed with an Assisted-by: MODEL_NAME MODEL_VERSION line appended to the commit message.
    • Please mention coding assistance in the PR description too (eg. by adding the same Assisted-by line from above)
    • Please describe the changes in your own words - we'd like to know you understand the changes being made!

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

- add a new duplicate attribute hint to existing ComponentUsagesChecker class
- minor refactors/optimization to the class
- add tests

@mbien mbien left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

You think this is something for NB 32? If yes please add the milestone. It would have to get in before freeze.

@NicolaIsotta

Copy link
Copy Markdown
Contributor Author

Yeah, I think this can go in safely. I'll merge later unless there are objections.

@mbien mbien added this to the NB32 milestone Oct 13, 2026
@NicolaIsotta
NicolaIsotta merged commit 3448686 into apache:master Oct 13, 2026
29 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in NetBeans JavaEE related Oct 13, 2026
@NicolaIsotta
NicolaIsotta deleted the jsf-duplicate-attributes branch October 13, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hints Java EE/Jakarta EE [ci] enable enterprise job

Projects

Development

Successfully merging this pull request may close these issues.

2 participants