Fix clang tidy issues

apache · Aug 18, 2023 · aff3e33 · aff3e33
1 parent 74a4ac6
commit aff3e33
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/extensions/openwsman/processors/SourceInitiatedSubscriptionListener.cpp b/extensions/openwsman/processors/SourceInitiatedSubscriptionListener.cpp
@@ -65,8 +65,8 @@ extern "C" {
 
 namespace org::apache::nifi::minifi::processors {
 
-SourceInitiatedSubscriptionListener::SourceInitiatedSubscriptionListener(std::string name, const utils::Identifier& uuid)
-    : Processor(std::move(name), uuid)
+SourceInitiatedSubscriptionListener::SourceInitiatedSubscriptionListener(std::string_view name, const utils::Identifier& uuid)
+    : Processor(name, uuid)
     , session_factory_(nullptr)
     , listen_port_(0U)
     , subscription_expiration_interval_(0)

diff --git a/extensions/openwsman/processors/SourceInitiatedSubscriptionListener.h b/extensions/openwsman/processors/SourceInitiatedSubscriptionListener.h
@@ -49,7 +49,7 @@ class SourceInitiatedSubscriptionListener : public core::Processor {
   static constexpr char const *INITIAL_EXISTING_EVENTS_STRATEGY_NONE = "None";
   static constexpr char const *INITIAL_EXISTING_EVENTS_STRATEGY_ALL = "All";
 
-  explicit SourceInitiatedSubscriptionListener(std::string name, const utils::Identifier& uuid = {});
+  explicit SourceInitiatedSubscriptionListener(std::string_view name, const utils::Identifier& uuid = {});
 
   EXTENSIONAPI static constexpr const char* Description = "This processor implements a Windows Event Forwarding Source Initiated Subscription server with the help of OpenWSMAN. "
       "Windows hosts can be set up to connect and forward Event Logs to this processor.";

diff --git a/extensions/sftp/processors/SFTPProcessorBase.cpp b/extensions/sftp/processors/SFTPProcessorBase.cpp
@@ -42,8 +42,8 @@
 
 namespace org::apache::nifi::minifi::processors {
 
-SFTPProcessorBase::SFTPProcessorBase(std::string name, const utils::Identifier& uuid)
-    : Processor(std::move(name), uuid),
+SFTPProcessorBase::SFTPProcessorBase(std::string_view name, const utils::Identifier& uuid)
+    : Processor(name, uuid),
       connection_timeout_(0),
       data_timeout_(0),
       strict_host_checking_(false),

diff --git a/extensions/sftp/processors/SFTPProcessorBase.h b/extensions/sftp/processors/SFTPProcessorBase.h
@@ -40,7 +40,7 @@ namespace org::apache::nifi::minifi::processors {
 
 class SFTPProcessorBase : public core::Processor {
  public:
-  SFTPProcessorBase(std::string name, const utils::Identifier& uuid);
+  SFTPProcessorBase(std::string_view name, const utils::Identifier& uuid);
   ~SFTPProcessorBase() override;
 
   static constexpr std::string_view PROXY_TYPE_DIRECT = "DIRECT";

diff --git a/extensions/standard-processors/tests/unit/ProcessorTests.cpp b/extensions/standard-processors/tests/unit/ProcessorTests.cpp
@@ -487,8 +487,8 @@ TEST_CASE("Test Find file", "[getfileCreate3]") {
 
 class TestProcessorNoContent : public minifi::core::Processor {
  public:
-  explicit TestProcessorNoContent(std::string name, const utils::Identifier& uuid = {})
-      : Processor(std::move(name), uuid) {
+  explicit TestProcessorNoContent(std::string_view name, const utils::Identifier& uuid = {})
+      : Processor(name, uuid) {
   }
 
   static constexpr const char* Description = "test resource";

diff --git a/libminifi/test/persistence-tests/PersistenceTests.cpp b/libminifi/test/persistence-tests/PersistenceTests.cpp
@@ -242,7 +242,7 @@ TEST_CASE("Processors Can Store FlowFiles", "[TestP1]") {
 
 class ContentUpdaterProcessor : public core::Processor {
  public:
-  ContentUpdaterProcessor(std::string name, const utils::Identifier& id) : Processor(std::move(name), id) {}
+  ContentUpdaterProcessor(std::string_view name, const utils::Identifier& id) : Processor(name, id) {}
 
   static constexpr bool SupportsDynamicProperties = false;
   static constexpr bool SupportsDynamicRelationships = false;