-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINIFICPP-2082 Move RocksDB stats to RepositoryMetrics #1540
Conversation
libminifi/include/core/state/nodes/RepositoryMetricsSourceStore.h
Outdated
Show resolved
Hide resolved
29f85d2
to
453104b
Compare
libminifi/src/core/state/nodes/RepositoryMetricsSourceStore.cpp
Outdated
Show resolved
Hide resolved
53b2a5c
to
f5b67d8
Compare
Signed-off-by: Ferenc Gerlits <[email protected]> This closes apache#1540
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I rebase this on top of the current main branch, then this test fails:
-------------------------------------------------------------------------------
Verify multiple metric nodes in logs
-------------------------------------------------------------------------------
/home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/libminifi/test/unit/LogMetricsPublisherTests.cpp:77
...............................................................................
/home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/libminifi/test/unit/LogMetricsPublisherTests.cpp:77: FAILED:
due to a fatal error condition:
SIGSEGV - Segmentation violation signal
f5b67d8
to
09d6029
Compare
Additional metrics were added for the rocksdb repositories in MINIFICPP-2022 which needs rocksdb repositories to be initialized to be able to open the rocksdb database and retrieve these metrics, which was missing in this PR. Fixed in 09d6029 |
Instead of printing the RocksDB specific metrics to the log file every 30 seconds, they are moved to the RepositoryMetrics. This way they can be published to any metric collector and should be able to print them to the log file as well periodically after MINIFICPP-2076 is merged.
Depends on MINIFICPP-2022
https://issues.apache.org/jira/browse/MINIFICPP-2082
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.