-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINIFICPP-2127 Add multipart upload support for PutS3Object processor #1586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaszm
reviewed
Jun 7, 2023
lordgamez
force-pushed
the
MINIFICPP-2127
branch
3 times, most recently
from
June 14, 2023 08:16
b199c4d
to
32c1a98
Compare
szaszm
reviewed
Jun 15, 2023
fgerlits
reviewed
Jun 16, 2023
fgerlits
reviewed
Jun 16, 2023
fgerlits
reviewed
Jun 19, 2023
lordgamez
force-pushed
the
MINIFICPP-2127
branch
from
June 19, 2023 14:57
5624af2
to
12fdfe2
Compare
fgerlits
approved these changes
Jun 19, 2023
lordgamez
force-pushed
the
MINIFICPP-2127
branch
from
June 20, 2023 07:34
ea2548e
to
b6e6b78
Compare
@szaszm Changed the state manager to be able to use it for multipart upload states in b91b756 It seems to be enough to return |
szaszm
reviewed
Jul 10, 2023
szaszm
reviewed
Jul 10, 2023
lordgamez
force-pushed
the
MINIFICPP-2127
branch
2 times, most recently
from
July 20, 2023 07:39
9e7a2d8
to
4a74f69
Compare
szaszm
reviewed
Jul 24, 2023
lordgamez
force-pushed
the
MINIFICPP-2127
branch
from
July 31, 2023 11:16
9ede5a7
to
7c87f76
Compare
szaszm
reviewed
Jul 31, 2023
szaszm
approved these changes
Jul 31, 2023
adamdebreceni
approved these changes
Aug 2, 2023
lordgamez
force-pushed
the
MINIFICPP-2127
branch
from
August 3, 2023 07:41
59dd271
to
b6d1016
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2127
https://issues.apache.org/jira/browse/MINIFICPP-2140
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.