-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINIFICPP-2135 Add SSL support for Prometheus reporter #1587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordgamez
force-pushed
the
MINIFICPP-2135
branch
from
June 14, 2023 07:33
381fe74
to
01931c9
Compare
lordgamez
commented
Jun 14, 2023
szaszm
reviewed
Jun 20, 2023
lordgamez
force-pushed
the
MINIFICPP-2135
branch
2 times, most recently
from
June 30, 2023 15:21
f360282
to
4ab3d5b
Compare
szaszm
approved these changes
Jul 14, 2023
fgerlits
reviewed
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added some nitpicks about documentation and formatting.
docker/test/integration/cluster/containers/PrometheusContainer.py
Outdated
Show resolved
Hide resolved
martinzink
approved these changes
Jul 14, 2023
lordgamez
force-pushed
the
MINIFICPP-2135
branch
from
July 14, 2023 15:09
4ab3d5b
to
45f72a6
Compare
fgerlits
approved these changes
Jul 14, 2023
lordgamez
force-pushed
the
MINIFICPP-2135
branch
from
July 20, 2023 06:51
45f72a6
to
d0b7458
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2135
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.