MINIFICPP-2129 Refactor threadpool #1606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaszm
reviewed
Jul 17, 2023
martinzink
force-pushed
the
MINIFICPP-2129
branch
from
1be53ab
to
6fdb7f1
Compare
szaszm
reviewed
Aug 1, 2023
Comment on lines
79
to
80
| done_with_checking.test_and_set(); | ||
| done_with_checking.notify_all(); |
There was a problem hiding this comment.
The indentation looks incorrect here
fgerlits
reviewed
Aug 8, 2023
martinzink
force-pushed
the
MINIFICPP-2129
branch
from
6fdb7f1
to
76c1153
Compare
szaszm
approved these changes
Aug 14, 2023
fgerlits
approved these changes
Aug 15, 2023
removed unneccesary comments on ThreadPool members removed duplicate using chrono_literals from ThreadPool.cpp
martinzink
force-pushed
the
MINIFICPP-2129
branch
from
76c1153
to
975ca26
Compare
lordgamez
approved these changes
Aug 16, 2023
adamdebreceni
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes MINIFICPP-2141
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.