Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-2183 fix MacOS CI failure #1629

Closed
wants to merge 1 commit into from

Conversation

martinzink
Copy link
Member

@martinzink martinzink commented Aug 15, 2023

I am not sure what exactly caused the failures only that I was able to reproduce it with cmake >= 3.27 and make as the generator. With ninja the problem doesnt occur, so I've changed generator that the mac CI uses to ninja.

I've also changed where the test resources are loaded from during lua/python tests because that also failed (couldnt reproduce locally), but this method is better anyways because the tests dont rely on the source folder. (and also the other tests work similarly)

I want to merge this PR asap, if we want we could further investigate what caused these issues, but it would be best if we regained macOS test coverage without further delays so the merging of new features can continue.


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@martinzink martinzink marked this pull request as ready for review August 15, 2023 19:44
@lordgamez lordgamez closed this in 2cef282 Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants